test: remove common.PORT from http tests

PR-URL: #7467 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jul 14, 2016 · 8273824 · 8273824
1 parent 066cefb
commit 8273824
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/test/parallel/test-http-client-keep-alive-release-before-finish.js b/test/parallel/test-http-client-keep-alive-release-before-finish.js
@@ -4,16 +4,18 @@ const http = require('http');
 
 const server = http.createServer((req, res) => {
   res.end();
-}).listen(common.PORT, common.mustCall(() => {
+}).listen(0, common.mustCall(() => {
   const agent = new http.Agent({
     maxSockets: 1,
     keepAlive: true
   });
 
+  const port = server.address().port;
+
   const post = http.request({
-    agent: agent,
+    agent,
     method: 'POST',
-    port: common.PORT,
+    port,
   }, common.mustCall((res) => {
     res.resume();
   }));
@@ -28,9 +30,9 @@ const server = http.createServer((req, res) => {
   }, 100);
 
   http.request({
-    agent: agent,
+    agent,
     method: 'GET',
-    port: common.PORT,
+    port,
   }, common.mustCall((res) => {
     server.close();
     res.connection.end();

diff --git a/test/parallel/test-http-no-read-no-dump.js b/test/parallel/test-http-no-read-no-dump.js
@@ -15,16 +15,18 @@ const server = http.createServer((req, res) => {
     res.end();
     onPause();
   });
-}).listen(common.PORT, common.mustCall(() => {
+}).listen(0, common.mustCall(() => {
   const agent = new http.Agent({
     maxSockets: 1,
     keepAlive: true
   });
 
+  const port = server.address().port;
+
   const post = http.request({
-    agent: agent,
+    agent,
     method: 'POST',
-    port: common.PORT,
+    port,
   }, common.mustCall((res) => {
     res.resume();
 
@@ -41,9 +43,9 @@ const server = http.createServer((req, res) => {
   post.write('initial');
 
   http.request({
-    agent: agent,
+    agent,
     method: 'GET',
-    port: common.PORT,
+    port,
   }, common.mustCall((res) => {
     server.close();
     res.connection.end();