http2: don't send trailers on a closed connection

There is a race condition between onStreamCloseResponse(), which removes the wantTrailers listener, and Http2Stream.close(), which will invalidate the connection. IE, sendTrailers can be called on a closed connection which would crash with a: Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed PR-URL: #23146 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Oct 4, 2018 · 8fe62f8 · 8fe62f8
1 parent f98d441
commit 8fe62f8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -330,7 +330,7 @@ function tryClose(fd) {
 function onStreamTrailers() {
   const stream = this[kOwner];
   stream[kState].trailersReady = true;
-  if (stream.destroyed)
+  if (stream.destroyed || stream.closed)
     return;
   if (!stream.emit('wantTrailers')) {
     // There are no listeners, send empty trailing HEADERS frame and close.