Skip to content

Commit

Permalink
benchmark: add remaining path benchmarks & optimize
Browse files Browse the repository at this point in the history
As a follow-up to 0d15161, this commit adds benchmarks for the rest
of the path functions and also forces V8 to optimize the functions
before starting the benchmark test.

PR-URL: #2103
Reviewed-By: Brendan Ashworth <[email protected]>
  • Loading branch information
nwoltman authored and brendanashworth committed Jul 27, 2015
1 parent ac70bc8 commit 99d9d7e
Show file tree
Hide file tree
Showing 10 changed files with 147 additions and 0 deletions.
26 changes: 26 additions & 0 deletions benchmark/path/basename.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
n: [1e6],
});

function main(conf) {
var n = +conf.n;
var p = path[conf.type];

// Force optimization before starting the benchmark
p.basename('/foo/bar/baz/asdf/quux.html');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.basename)');
p.basename('/foo/bar/baz/asdf/quux.html');

bench.start();
for (var i = 0; i < n; i++) {
p.basename('/foo/bar/baz/asdf/quux.html');
p.basename('/foo/bar/baz/asdf/quux.html', '.html');
}
bench.end(n);
}
25 changes: 25 additions & 0 deletions benchmark/path/dirname.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
n: [1e6],
});

function main(conf) {
var n = +conf.n;
var p = path[conf.type];

// Force optimization before starting the benchmark
p.dirname('/foo/bar/baz/asdf/quux');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.dirname)');
p.dirname('/foo/bar/baz/asdf/quux');

bench.start();
for (var i = 0; i < n; i++) {
p.dirname('/foo/bar/baz/asdf/quux');
}
bench.end(n);
}
26 changes: 26 additions & 0 deletions benchmark/path/extname.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
n: [1e6],
});

function main(conf) {
var n = +conf.n;
var p = path[conf.type];

// Force optimization before starting the benchmark
p.extname('index.html');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.extname)');
p.extname('index.html');

bench.start();
for (var i = 0; i < n; i++) {
p.extname('index.html');
p.extname('index');
}
bench.end(n);
}
7 changes: 7 additions & 0 deletions benchmark/path/format.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
Expand All @@ -23,6 +24,12 @@ function main(conf) {
name : 'index'
};

// Force optimization before starting the benchmark
p.format(test);
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.format)');
p.format(test);

bench.start();
for (var i = 0; i < n; i++) {
p.format(test);
Expand Down
7 changes: 7 additions & 0 deletions benchmark/path/isAbsolute.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
Expand All @@ -13,6 +14,12 @@ function main(conf) {
? ['//server', 'C:\\baz\\..', 'bar\\baz', '.']
: ['/foo/bar', '/baz/..', 'bar/baz', '.'];

// Force optimization before starting the benchmark
p.isAbsolute(tests[0]);
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.isAbsolute)');
p.isAbsolute(tests[0]);

bench.start();
for (var i = 0; i < n; i++) {
runTests(p, tests);
Expand Down
7 changes: 7 additions & 0 deletions benchmark/path/join.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
Expand All @@ -10,6 +11,12 @@ function main(conf) {
var n = +conf.n;
var p = path[conf.type];

// Force optimization before starting the benchmark
p.join('/foo', 'bar', '', 'baz/asdf', 'quux', '..');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.join)');
p.join('/foo', 'bar', '', 'baz/asdf', 'quux', '..');

bench.start();
for (var i = 0; i < n; i++) {
p.join('/foo', 'bar', '', 'baz/asdf', 'quux', '..');
Expand Down
7 changes: 7 additions & 0 deletions benchmark/path/normalize.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
Expand All @@ -10,6 +11,12 @@ function main(conf) {
var n = +conf.n;
var p = path[conf.type];

// Force optimization before starting the benchmark
p.normalize('/foo/bar//baz/asdf/quux/..');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.normalize)');
p.normalize('/foo/bar//baz/asdf/quux/..');

bench.start();
for (var i = 0; i < n; i++) {
p.normalize('/foo/bar//baz/asdf/quux/..');
Expand Down
28 changes: 28 additions & 0 deletions benchmark/path/parse.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
n: [1e6],
});

function main(conf) {
var n = +conf.n;
var p = path[conf.type];
var test = conf.type === 'win32'
? 'C:\\path\\dir\\index.html'
: '/home/user/dir/index.html';

// Force optimization before starting the benchmark
p.parse(test);
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.parse)');
p.parse(test);

bench.start();
for (var i = 0; i < n; i++) {
p.parse(test);
}
bench.end(n);
}
7 changes: 7 additions & 0 deletions benchmark/path/relative.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
Expand All @@ -10,6 +11,12 @@ function main(conf) {
var n = +conf.n;
var runTest = conf.type === 'win32' ? runWin32Test : runPosixTest;

// Force optimization before starting the benchmark
runTest();
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(path[conf.type].relative)');
runTest();

bench.start();
for (var i = 0; i < n; i++) {
runTest();
Expand Down
7 changes: 7 additions & 0 deletions benchmark/path/resolve.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var common = require('../common.js');
var path = require('path');
var v8 = require('v8');

var bench = common.createBenchmark(main, {
type: ['win32', 'posix'],
Expand All @@ -10,6 +11,12 @@ function main(conf) {
var n = +conf.n;
var p = path[conf.type];

// Force optimization before starting the benchmark
p.resolve('foo/bar', '/tmp/file/', '..', 'a/../subfile');
v8.setFlagsFromString('--allow_natives_syntax');
eval('%OptimizeFunctionOnNextCall(p.resolve)');
p.resolve('foo/bar', '/tmp/file/', '..', 'a/../subfile');

bench.start();
for (var i = 0; i < n; i++) {
p.resolve('foo/bar', '/tmp/file/', '..', 'a/../subfile');
Expand Down

0 comments on commit 99d9d7e

Please sign in to comment.