Skip to content

Commit

Permalink
node: fix leaking Context handle
Browse files Browse the repository at this point in the history
The call to node::Environment::GetCurrent(Isolate*) makes the call to
v8::Isolate::GetCurrentContext(). Doing so creates a new handle that
bubbled to the v8::SealHandleScope().

PR-URL: #3945
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: James Snell <[email protected]>
  • Loading branch information
trevnorris authored and rvagg committed Dec 4, 2015
1 parent 409f6a9 commit 9abcead
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3163,6 +3163,7 @@ static void EnableDebug(Environment* env) {

// Called from the main thread.
static void DispatchDebugMessagesAsyncCallback(uv_async_t* handle) {
HandleScope scope(node_isolate);
if (debugger_running == false) {
fprintf(stderr, "Starting debugger agent.\n");

Expand Down

0 comments on commit 9abcead

Please sign in to comment.