Skip to content

Commit

Permalink
lib: restrict usage of fetch related globals in core internals
Browse files Browse the repository at this point in the history
  • Loading branch information
aduh95 committed Feb 13, 2022
1 parent a137eca commit a2a4f40
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions lib/.eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ rules:
message: "Use `const { Atomics } = globalThis;` instead of the global."
- name: Blob
message: "Use `const { Blob } = require('buffer');` instead of the global."
- name: BroadcastChannel
message: "Use `const { BroadcastChannel } = require('internal/worker/io');` instead of the global."
- name: Buffer
message: "Use `const { Buffer } = require('buffer');` instead of the global."
- name: DOMException
Expand All @@ -47,18 +49,22 @@ rules:
message: "Use `const { Event } = require('internal/event_target');` instead of the global."
- name: EventTarget
message: "Use `const { EventTarget } = require('internal/event_target');` instead of the global."
- name: Headers
message: "Use `const { Headers } = require('internal/deps/undici/undici');` instead of the global."
# Intl is not available in primordials because it can be
# disabled with --without-intl build flag.
- name: Intl
message: "Use `const { Intl } = globalThis;` instead of the global."
- name: BroadcastChannel
message: "Use `const { BroadcastChannel } = require('internal/worker/io');` instead of the global."
- name: MessageChannel
message: "Use `const { MessageChannel } = require('internal/worker/io');` instead of the global."
- name: MessageEvent
message: "Use `const { MessageEvent } = require('internal/worker/io');` instead of the global."
- name: MessagePort
message: "Use `const { MessagePort } = require('internal/worker/io');` instead of the global."
- name: Request
message: "Use `const { Request } = require('internal/deps/undici/undici');` instead of the global."
- name: Response
message: "Use `const { Response } = require('internal/deps/undici/undici');` instead of the global."
# SharedArrayBuffer is not available in primordials because it can be
# disabled with --no-harmony-sharedarraybuffer CLI flag.
- name: SharedArrayBuffer
Expand All @@ -79,6 +85,8 @@ rules:
message: "Use `const { atob } = require('buffer');` instead of the global."
- name: btoa
message: "Use `const { btoa } = require('buffer');` instead of the global."
- name: fetch
message: "Use `const { fetch } = require('internal/deps/undici/undici');` instead of the global."
- name: global
message: "Use `const { globalThis } = primordials;` instead of `global`."
- name: globalThis
Expand Down

0 comments on commit a2a4f40

Please sign in to comment.