Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The test-stdin-from-from-file test runs a subprocess that verifies stdin can be piped from a file. The subprocess additionally attempts to verify that the file descriptor for stdin never gets closed. It used to do this by creating a TCP server and asserting that the associated file descriptor is greater than two. However this strategy doesn't work on windows, because servers don't have an associated file descriptor. With this patch an ordinary file is opened instead of creating a server. PR: #1067 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]>
- Loading branch information
abd3ecf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this commit has
PR:
rather thanPR-URL:
abd3ecf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg doh, I always use
PR:
. I'll use PR-URL next time.abd3ecf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now I know this isn't a one-off I've updated changelog-maker: nodejs/changelog-maker@04e1959