test: resolve process.setgid() error on Ubuntu

When the tests are run as root in Ubuntu, process.setgid() is called with 'nobody' as an argument. This throws an error in Ubuntu and is because, in Ubuntu, the equivalent of 'nobody' group is named as 'nogroup'. This commit sets gid to 'nobody' first and if it throws a "group id does not exist" error, it attempts to set gid to 'nogroup'. If it still causes an error, the error is thrown. PR-URL: #19755 Refs: #19594 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Apr 23, 2018 · b4e86f1 · b4e86f1
1 parent 18f41dd
commit b4e86f1
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/test/parallel/test-process-uid-gid.js b/test/parallel/test-process-uid-gid.js
@@ -61,7 +61,14 @@ if (process.getuid() !== 0) {
 
 // If we are running as super user...
 const oldgid = process.getgid();
-process.setgid('nobody');
+try {
+  process.setgid('nobody');
+} catch (err) {
+  if (err.message !== 'setgid group id does not exist') {
+    throw err;
+  }
+  process.setgid('nogroup');
+}
 const newgid = process.getgid();
 assert.notStrictEqual(newgid, oldgid);