child_process: clone spawn options argument

spawnSync() modifies the options argument. This commit makes a copy of options before any modifications occur. PR-URL: nodejs/node-v0.x-archive#9159 Reviewed-By: trevnorris - Trevor Norris <[email protected]>
nodejs · Aug 27, 2015 · b5a0abc · b5a0abc
1 parent 0363cf4
commit b5a0abc
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -967,6 +967,7 @@ function normalizeSpawnArguments(file /*, args, options*/) {
   else if (!util.isObject(options))
     throw new TypeError('options argument must be an object');
 
+  options = util._extend({}, options);
   args.unshift(file);
 
   var env = options.env || process.env;

diff --git a/test/common.js b/test/common.js
@@ -99,6 +99,17 @@ exports.spawnCat = function(options) {
 };
 
 
+exports.spawnSyncCat = function(options) {
+  var spawnSync = require('child_process').spawnSync;
+
+  if (process.platform === 'win32') {
+    return spawnSync('more', [], options);
+  } else {
+    return spawnSync('cat', [], options);
+  }
+};
+
+
 exports.spawnPwd = function(options) {
   var spawn = require('child_process').spawn;
 

diff --git a/test/simple/test-child-process-stdio.js b/test/simple/test-child-process-stdio.js
@@ -34,3 +34,7 @@ child = common.spawnPwd(options);
 
 assert.equal(child.stdout, null);
 assert.equal(child.stderr, null);
+
+options = {stdio: 'ignore'};
+child = common.spawnSyncCat(options);
+assert.deepEqual(options, {stdio: 'ignore'});