fs: fix fs.read when passing null value

PR-URL: #32479 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
nodejs · Mar 30, 2020 · b8b8e82 · b8b8e82
1 parent 1fc19b0
commit b8b8e82
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -485,10 +485,12 @@ function read(fd, buffer, offset, length, position, callback) {
       callback = offset;
     }
 
-    buffer = options.buffer || Buffer.alloc(16384);
-    offset = options.offset || 0;
-    length = options.length || buffer.length;
-    position = options.position;
+    ({
+      buffer = Buffer.alloc(16384),
+      offset = 0,
+      length = buffer.length,
+      position
+    } = options);
   }
 
   validateBuffer(buffer);

diff --git a/test/parallel/test-fs-read.js b/test/parallel/test-fs-read.js
@@ -80,6 +80,14 @@ assert.throws(
   }
 );
 
+['buffer', 'offset', 'length'].forEach((option) =>
+  assert.throws(
+    () => fs.read(fd, {
+      [option]: null
+    }),
+    `not throws when options.${option} is null`
+  ));
+
 assert.throws(
   () => fs.read(null, Buffer.alloc(1), 0, 1, 0),
   {