test_runner: hide failing tests title when all tests pass

PR-URL: #47370 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jul 6, 2023 · c4928f6 · c4928f6
1 parent a65dd0b
commit c4928f6
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/lib/internal/test_runner/reporter/spec.js b/lib/internal/test_runner/reporter/spec.js
@@ -124,6 +124,10 @@ class SpecReporter extends Transform {
     callback(null, this.#handleEvent({ type, data }));
   }
   _flush(callback) {
+    if (this.#failedTests.length === 0) {
+      callback(null, '');
+      return;
+    }
     const results = [`\n${colors['test:fail']}${symbols['test:fail']}failing tests:${white}\n`];
     for (let i = 0; i < this.#failedTests.length; i++) {
       ArrayPrototypePush(results, this.#formatTestReport(

diff --git a/test/message/test_runner_spec_reporter_successful.js b/test/message/test_runner_spec_reporter_successful.js
@@ -0,0 +1,6 @@
+// Flags: --no-warnings --test-reporter=spec
+'use strict';
+require('../common');
+const { it } = require('node:test');
+
+it('should pass', () => {});
diff --git a/test/message/test_runner_spec_reporter_successful.out b/test/message/test_runner_spec_reporter_successful.out
@@ -0,0 +1,9 @@
+* should pass *(*ms)*
+*tests 1*
+*suites 0*
+*pass 1*
+*fail 0*
+*cancelled 0*
+*skipped 0*
+*todo 0*
+*duration_ms *