dgram: fix possibly deoptimizing use of arguments

This commit adds a guard against an out of bounds access of arguments, and replaces another use of arguments with a named function parameter. Refs: #10323 PR-URL: #11242 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 9, 2017 · c61d7d2 · c61d7d2
1 parent eec96ef
commit c61d7d2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/dgram.js b/lib/dgram.js
@@ -134,7 +134,7 @@ function replaceHandle(self, newHandle) {
   self._handle = newHandle;
 }
 
-Socket.prototype.bind = function(port_ /*, address, callback*/) {
+Socket.prototype.bind = function(port_, address_ /*, callback*/) {
   let port = port_;
 
   this._healthCheck();
@@ -144,7 +144,7 @@ Socket.prototype.bind = function(port_ /*, address, callback*/) {
 
   this._bindState = BIND_STATE_BINDING;
 
-  if (typeof arguments[arguments.length - 1] === 'function')
+  if (arguments.length && typeof arguments[arguments.length - 1] === 'function')
     this.once('listening', arguments[arguments.length - 1]);
 
   if (port instanceof UDP) {
@@ -161,7 +161,7 @@ Socket.prototype.bind = function(port_ /*, address, callback*/) {
     exclusive = !!port.exclusive;
     port = port.port;
   } else {
-    address = typeof arguments[1] === 'function' ? '' : arguments[1];
+    address = typeof address_ === 'function' ? '' : address_;
     exclusive = false;
   }