fixup! fs: improve error performance fori fsyncSync

nodejs · Sep 27, 2023 · c710f94 · c710f94
1 parent 19748b8
commit c710f94
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/internal/fs/sync.js b/lib/internal/fs/sync.js
@@ -89,6 +89,8 @@ function close(fd) {
 }
 
 function fsync(fd) {
+  fd = getValidatedFd(fd);
+
   return binding.fsyncSync(fd);
 }
 

diff --git a/typings/internalBinding/fs.d.ts b/typings/internalBinding/fs.d.ts
@@ -94,11 +94,11 @@ declare namespace InternalFSBinding {
   function fstat(fd: number, useBigint: boolean, usePromises: typeof kUsePromises): Promise<Float64Array | BigUint64Array>;
   function fstat(fd: number, useBigint: true, usePromises: typeof kUsePromises): Promise<BigUint64Array>;
   function fstat(fd: number, useBigint: false, usePromises: typeof kUsePromises): Promise<Float64Array>;
-  function fsync(fd: number): void;
 
-  function fsyncSync(fd: number, req: FSReqCallback): void;
-  function fsyncSync(fd: number, req: undefined, ctx: FSSyncContext): void;
-  function fsyncSync(fd: number, usePromises: typeof kUsePromises): Promise<void>;
+  function fsync(fd: number, req: FSReqCallback): void;
+  function fsync(fd: number, req: undefined, ctx: FSSyncContext): void;
+  function fsync(fd: number, usePromises: typeof kUsePromises): Promise<void>;
+  function fsyncSync(fd: number): void;
 
   function ftruncate(fd: number, len: number, req: FSReqCallback): void;
   function ftruncate(fd: number, len: number, req: undefined, ctx: FSSyncContext): void;