http2: do not falsely emit 'aborted' on push

A push stream should have its writable side closed upon receipt, to avoid emitting the 'aborted' event when the readable side is closed. Backport-PR-URL: #22850 PR-URL: #22878 Fixes: #22851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Oct 16, 2018 · ca933ce · ca933ce
1 parent 49f44f3
commit ca933ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -220,6 +220,7 @@ function onSessionHeaders(handle, id, cat, flags, headers) {
       }
     } else {
       stream = new ClientHttp2Stream(session, handle, id, opts);
+      stream.end();
     }
     if (endOfStream)
       stream[kState].endAfterHeaders = true;

diff --git a/test/parallel/test-http2-server-push-stream.js b/test/parallel/test-http2-server-push-stream.js
@@ -54,6 +54,7 @@ server.listen(0, common.mustCall(() => {
       assert.strictEqual(headers['content-type'], 'text/html');
       assert.strictEqual(headers['x-push-data'], 'pushed by server');
     }));
+    stream.on('aborted', common.mustNotCall());
   }));
 
   let data = '';