dgram: add nread assertion to UDPWrap::OnRecv

This asserts that the number of bytes received by the socket is less than or equal to the size allocated for the temporary storage. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40295 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
nodejs · Oct 9, 2021 · cca9b95 · cca9b95
1 parent 7723148
commit cca9b95
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc
@@ -20,7 +20,6 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 #include "udp_wrap.h"
-#include "allocated_buffer-inl.h"
 #include "env-inl.h"
 #include "node_buffer.h"
 #include "node_sockaddr-inl.h"
@@ -725,6 +724,7 @@ void UDPWrap::OnRecv(ssize_t nread,
   } else if (nread == 0) {
     bs = ArrayBuffer::NewBackingStore(isolate, 0);
   } else {
+    CHECK_LE(static_cast<size_t>(nread), bs->ByteLength());
     bs = BackingStore::Reallocate(isolate, std::move(bs), nread);
   }