-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tls: reduce TLS 'close' event listener warnings
Without this, some heavy usage of TLS sockets can result in MaxListenersExceededWarning firing, from the 'this.on('close', ...)' line here. These appear to come from reinitializeHandle, which calls _wrapHandle repeatedly on the same socket instance. PR-URL: #50136 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
- Loading branch information
Showing
2 changed files
with
48 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Flags: --expose-internals | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
|
||
if (!common.hasCrypto) { | ||
common.skip('missing crypto'); | ||
} | ||
|
||
const events = require('events'); | ||
const fixtures = require('../common/fixtures'); | ||
const tls = require('tls'); | ||
const { kReinitializeHandle } = require('internal/net'); | ||
|
||
// Test that repeated calls to kReinitializeHandle() do not result in repeatedly | ||
// adding new listeners on the socket (i.e. no MaxListenersExceededWarnings) | ||
|
||
process.on('warning', common.mustNotCall()); | ||
|
||
const server = tls.createServer({ | ||
key: fixtures.readKey('agent1-key.pem'), | ||
cert: fixtures.readKey('agent1-cert.pem') | ||
}); | ||
|
||
server.listen(0, common.mustCall(function() { | ||
const socket = tls.connect({ | ||
port: this.address().port, | ||
rejectUnauthorized: false | ||
}); | ||
|
||
socket.on('secureConnect', common.mustCall(function() { | ||
for (let i = 0; i < events.defaultMaxListeners + 1; i++) { | ||
socket[kReinitializeHandle](); | ||
} | ||
|
||
socket.destroy(); | ||
})); | ||
|
||
socket.on('close', function() { | ||
server.close(); | ||
}); | ||
})); |