Skip to content

Commit

Permalink
test: skip node-api/test_worker_terminate_finalization
Browse files Browse the repository at this point in the history
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731

PR-URL: #34732
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
  • Loading branch information
addaleax authored and mmarchini committed Aug 12, 2020
1 parent fd038a1 commit cf5d7c0
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test/node-api/test_worker_terminate_finalization/test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';
const common = require('../../common');

// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind.
// Refs: https://github.com/nodejs/node/issues/34731
common.skip('Reference management in N-API leaks memory');

const { Worker, isMainThread } = require('worker_threads');

if (isMainThread) {
Expand Down

0 comments on commit cf5d7c0

Please sign in to comment.