stream: improve views validation on BYOBRequest

- This throws if the view is zero-length when there is an active reader when using `ReadableStreamBYOBRequest.respondWithNewView()`. - By doing that, we can get all tests passed in `readable-byte-streams/bad-buffers-and-views.any.js`. Signed-off-by: Daeyeon Jeong [email protected]
nodejs · Aug 6, 2022 · d2b1fd7 · d2b1fd7
1 parent 0a2c910
commit d2b1fd7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -2516,6 +2516,15 @@ function readableByteStreamControllerRespondWithNewView(controller, view) {
   const viewBuffer = ArrayBufferViewGetBuffer(view);
   const viewBufferByteLength = ArrayBufferGetByteLength(viewBuffer);
 
+  if (stream[kState].state === 'closed') {
+    if (viewByteLength !== 0)
+      throw new ERR_INVALID_STATE.TypeError('View is not zero-length');
+  } else {
+    assert(stream[kState].state === 'readable');
+    if (viewByteLength === 0)
+      throw new ERR_INVALID_STATE.TypeError('View is zero-length');
+  }
+
   const {
     byteOffset,
     byteLength,

diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json
@@ -4,8 +4,5 @@
   },
   "transferable/deserialize-error.window.js": {
     "skip": "Browser-specific test"
-  },
-  "readable-byte-streams/bad-buffers-and-views.any.js": {
-    "fail": "TODO: implement detached ArrayBuffer support"
   }
 }