Skip to content

Commit

Permalink
build,test: make building addon tests less fragile
Browse files Browse the repository at this point in the history 
* Get rid of recursive `make` when building the node binary.  An earlier
  commit makes GYP write out rules that we can use for proper dependency
  tracking.

* Use module name 'binding' in addons.md and addons-napi/*/binding.gyp.
  This massively simplifies the logic for generating the build rules.

* Check in auto-generated add-on tests from `doc/api/addons.md`.  The
  files change rarely and generating them dynamically causes no end of
  race conditions and special-casing during the build.

PR-URL: #17407
Reviewed-By: Richard Lau <[email protected]>
  • Loading branch information
@bnoordhuis @BridgeAR
bnoordhuis authored and BridgeAR committed Jan 21, 2018
1 parent c668263 commit d9b59de
Show file tree
Hide file tree
Showing 95 changed files with 917 additions and 301 deletions.
1 change: 0 additions & 1 deletion .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ ipch/
/npm.wxs
/tools/msvs/npm.wixobj
/tools/msvs/genfiles/
/test/addons/??_*/
email.md
deps/v8-*
deps/icu
Expand Down
Loading

0 comments on commit d9b59de

Please sign in to comment.