Revert "path: resolve normalize drive letter to lower case"

This reverts commit f6e5740. Changing drive letters to lowercase violates the principle of least surprise. Other functions that do this should get fixed too. Conflicts: lib/path.js PR-URL: #100 Reviewed-By: Bert Belder <[email protected]>
nodejs · Dec 8, 2014 · e24fa83 · e24fa83
1 parent e3aa802
commit e24fa83
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/lib/path.js b/lib/path.js
@@ -162,12 +162,6 @@ win32.resolve = function() {
   resolvedTail = normalizeArray(resolvedTail.split(/[\\\/]+/).filter(f),
                                 !resolvedAbsolute).join('\\');
 
-  // If device is a drive letter, we'll normalize to lower case.
-  if (resolvedDevice && resolvedDevice.charAt(1) === ':') {
-    resolvedDevice = resolvedDevice[0].toLowerCase() +
-        resolvedDevice.substr(1);
-  }
-
   return (resolvedDevice + (resolvedAbsolute ? '\\' : '') + resolvedTail) ||
          '.';
 };

diff --git a/test/simple/test-module-nodemodulepaths.js b/test/simple/test-module-nodemodulepaths.js
@@ -21,7 +21,6 @@
 
 var common = require('../common');
 var assert = require('assert');
-var path = require('path');
 
 var module = require('module');
 
@@ -30,7 +29,7 @@ var isWindows = process.platform === 'win32';
 var file, delimiter, paths;
 
 if (isWindows) {
-  file = path.normalize('C:\\Users\\Rocko Artischocko\\node_stuff\\foo');
+  file = 'C:\\Users\\Rocko Artischocko\\node_stuff\\foo';
   delimiter = '\\'
 } else {
   file = '/usr/test/lib/node_modules/npm/foo';
@@ -40,4 +39,4 @@ if (isWindows) {
 paths = module._nodeModulePaths(file);
 
 assert.ok(paths.indexOf(file + delimiter + 'node_modules') !== -1);
-assert.ok(Array.isArray(paths));
+assert.ok(Array.isArray(paths));
diff --git a/test/simple/test-path.js b/test/simple/test-path.js
@@ -311,7 +311,7 @@ if (isWindows) {
        [['c:/ignore', 'd:\\a/b\\c/d', '\\e.exe'], 'd:\\e.exe'],
        [['c:/ignore', 'c:/some/file'], 'c:\\some\\file'],
        [['d:/ignore', 'd:some/dir//'], 'd:\\ignore\\some\\dir'],
-       [['.'], path.normalize(process.cwd())],
+       [['.'], process.cwd()],
        [['//server/share', '..', 'relative\\'], '\\\\server\\share\\relative'],
        [['c:/', '//'], 'c:\\'],
        [['c:/', '//dir'], 'c:\\dir'],