Skip to content

Commit

Permalink
src: avoid copying string in fs_permission
Browse files Browse the repository at this point in the history
PR-URL: #47746
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
  • Loading branch information
anonrig authored and targos committed May 3, 2023
1 parent 33d1bd3 commit e948bec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/permission/fs_permission.cc
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ void FSPermission::Apply(const std::string& allow, PermissionScope scope) {
}
}

void FSPermission::GrantAccess(PermissionScope perm, std::string res) {
void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
const std::string path = WildcardIfDir(res);
if (perm == PermissionScope::kFileSystemRead) {
granted_in_fs_.Insert(path);
Expand Down
2 changes: 1 addition & 1 deletion src/permission/fs_permission.h
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class FSPermission final : public PermissionBase {
};

private:
void GrantAccess(PermissionScope scope, std::string param);
void GrantAccess(PermissionScope scope, const std::string& param);
void RestrictAccess(PermissionScope scope,
const std::vector<std::string>& params);
// fs granted on startup
Expand Down

0 comments on commit e948bec

Please sign in to comment.