cluster: close ownerless handles on disconnect()

When a worker is disconnecting, it shuts down all of the handles it is waiting on. It is possible that a handle does not have an owner, which causes a crash. This commit closes such handles without accessing the missing owner. Fixes: #6561 PR-URL: #6909 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
nodejs · Jul 12, 2016 · f152adf · f152adf
1 parent c0a42bc
commit f152adf
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/cluster.js b/lib/cluster.js
@@ -703,7 +703,11 @@ function workerInit() {
       const handle = handles[key];
       delete handles[key];
       waitingCount++;
-      handle.owner.close(checkWaitingCount);
+
+      if (handle.owner)
+        handle.owner.close(checkWaitingCount);
+      else
+        handle.close(checkWaitingCount);
     }
 
     checkWaitingCount();