crypto: remove unneeded guard

createCFRGRaw() will always return an object. The error for an undefined return value will never occur. PR-URL: #43856 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jul 31, 2022 · f953b22 · f953b22
1 parent c6ec99b
commit f953b22
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/internal/crypto/cfrg.js b/lib/internal/crypto/cfrg.js
@@ -291,8 +291,6 @@ async function cfrgImportKey(
     case 'raw': {
       verifyAcceptableCfrgKeyUse(name, 'public', usagesSet);
       keyObject = createCFRGRawKey(name, keyData, true);
-      if (keyObject === undefined)
-        throw lazyDOMException('Unable to import CFRG key', 'OperationError');
       break;
     }
   }

diff --git a/lib/internal/crypto/keys.js b/lib/internal/crypto/keys.js
@@ -85,7 +85,7 @@ for (const m of [[kKeyEncodingPKCS1, 'pkcs1'], [kKeyEncodingPKCS8, 'pkcs8'],
   encodingNames[m[0]] = m[1];
 
 // Creating the KeyObject class is a little complicated due to inheritance
-// and that fact that KeyObjects should be transferrable between threads,
+// and the fact that KeyObjects should be transferrable between threads,
 // which requires the KeyObject base class to be implemented in C++.
 // The creation requires a callback to make sure that the NativeKeyObject
 // base class cannot exist without the other KeyObject implementations.