-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note that whatwg-url tests should not be modified #12793
Labels
good first issue
Issues that are suitable for first-time contributors.
test
Issues and PRs related to the tests.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
wip
Issues and PRs that are still a work in progress.
Comments
gibfahn
added
good first issue
Issues that are suitable for first-time contributors.
mentor-available
test
Issues and PRs related to the tests.
labels
May 2, 2017
Tips: the whatwg-url tests are |
mscdex
added
the
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
label
May 2, 2017
@gibfahn added "Since they are Imported Tests" to first comment if that's Ok. |
Additional information:
|
4 tasks
3 tasks
addaleax
pushed a commit
that referenced
this issue
Jul 22, 2017
Added comments to whatwg-url tests that they should not be changed until modifications are merged upstream as per "Web Platform Tests" guidelines PR-URL: #14355 Fixes: #12793 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fishrock123
pushed a commit
that referenced
this issue
Jul 24, 2017
Added comments to whatwg-url tests that they should not be changed until modifications are merged upstream as per "Web Platform Tests" guidelines PR-URL: #14355 Fixes: #12793 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Issues that are suitable for first-time contributors.
test
Issues and PRs related to the tests.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
wip
Issues and PRs that are still a work in progress.
Add a comment to the whatwg-url tests to document that we should not modify them since they are imported tests.
Refs: #12669 (comment) and #12743 (comment)
cc/ @Trott @joyeecheung @cjihrig
The text was updated successfully, but these errors were encountered: