Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of OpenSSL-1.0.2 #1423

Closed
indutny opened this issue Apr 14, 2015 · 2 comments
Closed

Make use of OpenSSL-1.0.2 #1423

indutny opened this issue Apr 14, 2015 · 2 comments
Assignees
@indutny
Labels
openssl Issues and PRs related to the OpenSSL dependency.

Comments

@indutny
Copy link
Member

indutny commented Apr 14, 2015

Replace ClientHello parser with it.
@indutny indutny self-assigned this Apr 14, 2015
@Fishrock123 Fishrock123 added the openssl Issues and PRs related to the OpenSSL dependency. label Apr 14, 2015
indutny added a commit to indutny/io.js that referenced this issue Apr 18, 2015
@indutny
tls: use SSL_set_cert_cb for async SNI/OCSP
0a9c681 
Do not enable ClientHello parser for async SNI/OCSP. Use new
OpenSSL-1.0.2's API `SSL_set_cert_cb` to pause the handshake process and
load the cert/OCSP response asynchronously. Hopefuly this will make
whole async SNI/OCSP process much faster and will eventually let us
remove the ClientHello parser itself (which is currently used only for
async session, see nodejs#1462 for the discussion of removing it).

NOTE: Ported our code to `SSL_CTX_add1_chain_cert` to use
`SSL_CTX_get0_chain_certs` in `CertCbDone`. Test provided for this
feature.

Fix: nodejs#1423
@indutny indutny mentioned this issue Apr 18, 2015
Closed
indutny added a commit to indutny/io.js that referenced this issue Apr 18, 2015
@indutny
tls: use SSL_set_cert_cb for async SNI/OCSP
8c05fed 
Do not enable ClientHello parser for async SNI/OCSP. Use new
OpenSSL-1.0.2's API `SSL_set_cert_cb` to pause the handshake process and
load the cert/OCSP response asynchronously. Hopefuly this will make
whole async SNI/OCSP process much faster and will eventually let us
remove the ClientHello parser itself (which is currently used only for
async session, see nodejs#1462 for the discussion of removing it).

NOTE: Ported our code to `SSL_CTX_add1_chain_cert` to use
`SSL_CTX_get0_chain_certs` in `CertCbDone`. Test provided for this
feature.

Fix: nodejs#1423
indutny added a commit to indutny/io.js that referenced this issue Apr 19, 2015
@indutny
tls: use SSL_set_cert_cb for async SNI/OCSP
7b45a8f 
Do not enable ClientHello parser for async SNI/OCSP. Use new
OpenSSL-1.0.2's API `SSL_set_cert_cb` to pause the handshake process and
load the cert/OCSP response asynchronously. Hopefuly this will make
whole async SNI/OCSP process much faster and will eventually let us
remove the ClientHello parser itself (which is currently used only for
async session, see nodejs#1462 for the discussion of removing it).

NOTE: Ported our code to `SSL_CTX_add1_chain_cert` to use
`SSL_CTX_get0_chain_certs` in `CertCbDone`. Test provided for this
feature.

Fix: nodejs#1423
indutny added a commit to indutny/io.js that referenced this issue Apr 24, 2015
@indutny
tls: use SSL_set_cert_cb for async SNI/OCSP
52ec001 
Do not enable ClientHello parser for async SNI/OCSP. Use new
OpenSSL-1.0.2's API `SSL_set_cert_cb` to pause the handshake process and
load the cert/OCSP response asynchronously. Hopefuly this will make
whole async SNI/OCSP process much faster and will eventually let us
remove the ClientHello parser itself (which is currently used only for
async session, see nodejs#1462 for the discussion of removing it).

NOTE: Ported our code to `SSL_CTX_add1_chain_cert` to use
`SSL_CTX_get0_chain_certs` in `CertCbDone`. Test provided for this
feature.

Fix: nodejs#1423
shigeki pushed a commit to shigeki/node that referenced this issue Apr 28, 2015
@indutny
tls: use SSL_set_cert_cb for async SNI/OCSP
16d2ac8 
Do not enable ClientHello parser for async SNI/OCSP. Use new
OpenSSL-1.0.2's API `SSL_set_cert_cb` to pause the handshake process and
load the cert/OCSP response asynchronously. Hopefuly this will make
whole async SNI/OCSP process much faster and will eventually let us
remove the ClientHello parser itself (which is currently used only for
async session, see nodejs#1462 for the discussion of removing it).

NOTE: Ported our code to `SSL_CTX_add1_chain_cert` to use
`SSL_CTX_get0_chain_certs` in `CertCbDone`. Test provided for this
feature.

Fix: nodejs#1423
indutny added a commit that referenced this issue May 1, 2015
@indutny
tls: use SSL_set_cert_cb for async SNI/OCSP
550c263 
Do not enable ClientHello parser for async SNI/OCSP. Use new
OpenSSL-1.0.2's API `SSL_set_cert_cb` to pause the handshake process and
load the cert/OCSP response asynchronously. Hopefuly this will make
whole async SNI/OCSP process much faster and will eventually let us
remove the ClientHello parser itself (which is currently used only for
async session, see #1462 for the discussion of removing it).

NOTE: Ported our code to `SSL_CTX_add1_chain_cert` to use
`SSL_CTX_get0_chain_certs` in `CertCbDone`. Test provided for this
feature.

Fix: #1423
PR-URL: #1464
Reviewed-By: Shigeki Ohtsu <[email protected]>
@Fishrock123
Copy link
Contributor

Can this be closed now that #1464 landed, or is this larger than that? :)

@indutny
Copy link
Member Author

indutny commented May 13, 2015

Yep, please close it. (On a bad internet atm).

On Wed, May 13, 2015 at 7:20 PM, Jeremiah Senkpiel <[email protected]

wrote:

Can this be closed now that #1464
#1464 landed, or is this larger than
that? :)

—
Reply to this email directly or view it on GitHub
#1423 (comment).

Fishrock123 pushed a commit to Fishrock123/node that referenced this issue May 19, 2015
@indutny @Fishrock123
tls: use SSL_set_cert_cb for async SNI/OCSP
592230a 
Do not enable ClientHello parser for async SNI/OCSP. Use new
OpenSSL-1.0.2's API `SSL_set_cert_cb` to pause the handshake process and
load the cert/OCSP response asynchronously. Hopefuly this will make
whole async SNI/OCSP process much faster and will eventually let us
remove the ClientHello parser itself (which is currently used only for
async session, see nodejs#1462 for the discussion of removing it).

NOTE: Ported our code to `SSL_CTX_add1_chain_cert` to use
`SSL_CTX_get0_chain_certs` in `CertCbDone`. Test provided for this
feature.

Fix: nodejs#1423
PR-URL: nodejs#1464
Reviewed-By: Shigeki Ohtsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indutny indutny

Labels
openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tls: use SSL_set_cert_cb for async SNI/OCSP indutny/io.js
2 participants
@indutny @Fishrock123