Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if test suite is aborted early tools/doc/node_modules and tools/doc/package-lock.json are not removed #17216

Closed
MylesBorins opened this issue Nov 22, 2017 · 0 comments · Fixed by #17224
Closed

if test suite is aborted early tools/doc/node_modules and tools/doc/package-lock.json are not removed #17216

MylesBorins opened this issue Nov 22, 2017 · 0 comments · Fixed by #17224
Labels
good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Comments

@MylesBorins
Copy link
Contributor

this is quite weird and confusing... not only are these files sticking around but they are being tracked by git

likely the simplest solution for now is to add them to the .gitignore, but we likely should be finding a better way of handling these temporary dependencies
@MylesBorins MylesBorins added the good first issue Issues that are suitable for first-time contributors. label Nov 22, 2017
@RichardLitt RichardLitt mentioned this issue Nov 22, 2017
Merged
1 task
@MylesBorins MylesBorins changed the title if test suite is aborted early doc/node_modules and doc/package-lock.json are not removed if test suite is aborted early tools/doc/node_modules and tools/doc/package-lock.json are not removed Nov 22, 2017
@fiso fiso mentioned this issue Nov 22, 2017
Closed
1 task
@mscdex mscdex added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Nov 22, 2017
refack pushed a commit to RichardLitt/node that referenced this issue Nov 24, 2017
@RichardLitt @refack
tools: fix gitignore for tools/doc/
887e232 
PR-URL: nodejs#17224
Fixes: nodejs#17216
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this issue Dec 12, 2017
@RichardLitt @MylesBorins
tools: fix gitignore for tools/doc/
39fc00b 
PR-URL: #17224
Fixes: #17216
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this issue Dec 12, 2017
@RichardLitt @MylesBorins
tools: fix gitignore for tools/doc/
f0f32dc 
PR-URL: #17224
Fixes: #17216
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
gibfahn pushed a commit that referenced this issue Jan 3, 2018
@RichardLitt @gibfahn
tools: fix gitignore for tools/doc/
eb3db34 
PR-URL: #17224
Fixes: #17216
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
2 participants
@mscdex @MylesBorins