-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raspberry Pi 1 test failure test-timers-unrefd-interval-still-fires.js #1781
Comments
Looks like it's timing related, but if it is that means only 3 timers set to 1ms are managing to fire in 100ms.. |
Gues we could try |
Couldn't reproduce in 1000 runs on a 700 Mhz RPi B model using 2.1.0 release. Trying master now. |
@silverwind did you ever reproduce this? I feel like I haven't seen it in a while. |
Don't think so. I've already replaced my RPi with a RPi2, so can't test anymore. |
If it still happens on CI, we can just use |
Closing, we haven't seen it recently. (Also I don't actually believe that test can take more than 100ms besides startup...) |
Rely more on timers implementation rather than arbitrary timeouts. Refs: nodejs#1781 PR-URL: nodejs#3550 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Rely more on timers implementation rather than arbitrary timeouts. Refs: #1781 PR-URL: #3550 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Rely more on timers implementation rather than arbitrary timeouts. Refs: #1781 PR-URL: #3550 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Rely more on timers implementation rather than arbitrary timeouts. Refs: #1781 PR-URL: #3550 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Probably an intermittent and this is running on an original Pi B, not a B+ so very likely time-related, but regardless, we need to make it more robust.
The text was updated successfully, but these errors were encountered: