Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: if-error-has-good-stack is broken on windows #18377

Closed
joyeecheung opened this issue Jan 25, 2018 · 1 comment
Closed

test: if-error-has-good-stack is broken on windows #18377

joyeecheung opened this issue Jan 25, 2018 · 1 comment

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Jan 25, 2018

https://ci.nodejs.org/job/node-test-binary-windows/14484/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=2/console

match failed
line=4
expect=^\ \ \ \ at\ z\ \(.*\/if\-error\-has\-good\-stack\.js\:.*\:.*$
actual=    at z (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:19:14)
not ok 497 message/if-error-has-good-stack
  ---
  duration_ms: 0.212
  severity: fail
  stack: |-
    assert.js:499
        throw newErr;
        ^
    
    AssertionError [ERR_ASSERTION]: ifError got unwanted exception: test error
        at z (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:19:14)
        at y (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:20:7)
        at x (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:21:5)
        at Object.<anonymous> (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:22:3)
        at c (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:11:13)
        at b (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:12:7)
        at a (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:13:5)
        at Object.<anonymous> (c:\workspace\node-test-binary-windows\test\message\if-error-has-good-stack.js:14:3)
        at Module._compile (module.js:661:30)
        at Object.Module._extensions..js (module.js:672:10)
        at Module.load (module.js:578:32)
        at tryModuleLoad (module.js:518:12)
        at Function.Module._load (module.js:510:3)
        at Function.Module.runMain (module.js:702:10)

There is a / in the filename which cannot be matched on Windows

cc @BridgeAR

@joyeecheung
Copy link
Member Author

Fix in #18378

MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
PR-URL: nodejs#18378
Fixes: nodejs#18377
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant