Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder authors in README.md #1972

Closed
jbergstroem opened this issue Jun 14, 2015 · 16 comments
Closed

Reorder authors in README.md #1972

jbergstroem opened this issue Jun 14, 2015 · 16 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@jbergstroem
Copy link
Member

(brought up in #1966, moved to its own place)

@rvagg suggested that we should reorder authors to remove any significance to their wg membership, such as when they joined or if they are part of the TC.

Lets agree on how this should be ordered. So far, last name or github username seems to be the two options. I like the idea of using the github username (and subsequently moving that ahead of name/email).

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Jun 14, 2015
@mscdex
Copy link
Contributor

mscdex commented Jun 14, 2015

Anything that makes it easier to simply copy and paste for Reviewed-By: lines 😀

@jbergstroem
Copy link
Member Author

@mscdex that's already solved by #1966 👍

@silverwind
Copy link
Contributor

@mscdex

function revline() {
  git log | grep -i --color=never reviewed.+$1 | head -1 | xargs | tee >(pbcopy)
}

Needs a second terminal, but I'm sure there's a way to integrate this into vim too.

@mscdex
Copy link
Contributor

mscdex commented Jun 14, 2015

@silverwind It's actually usually easier/faster for me to grab it from the readme. I'm not always at a machine with git and such installed.

@silverwind
Copy link
Contributor

How about this format? (Would have put the real name in parens, but that would kill copiability)

@mscdex how do you merge witout git installed? 😯

@mscdex
Copy link
Contributor

mscdex commented Jun 14, 2015

@silverwind I suppose that format is ok.

@jbergstroem
Copy link
Member Author

I'm ok with that too.

@silverwind
Copy link
Contributor

And of course, sort by username.

@chrisdickinson
Copy link
Contributor

I am only sort of kidding here, but maybe we should sort by sha1 hash of collaborator line? I'd like to encourage folks to spell their names using whatever orthography they would naturally use, and sha1 gets us away from having to figure out how to sort multiple orthographies.

Edit: as @silverwind suggests, sorting by username would also work and involve far less hashing :)

Needs a second terminal, but I'm sure there's a way to integrate this into vim too.

You should be able to just do :!revline (I think.) If not, turning it into a tiny shell script on $PATH would work.

@piscisaureus
Copy link
Contributor

@rvagg suggested that we should reorder authors to remove any significance to their wg membership, such as when they joined or if they are part of the TC.

Was any motivation given?

@jbergstroem
Copy link
Member Author

@piscisaureus here's the full quote from the PR:

I've been thinking that maybe putting them in full alphabetical order would be best, TC members included, it decreases the importance of the TC slightly which I think is appropriate for how this project actually works.

Thoughts anyone?

@trevnorris
Copy link
Contributor

Don't fully agree with that sentiment. While all collaborators are equals in terms of signing off a PR, the TSC is the team that has the absolute final say when something is controversial. So I believe that list of names should be at the top, not to show superiority but instead to make it easier for anyone to find their information.

@brendanashworth
Copy link
Contributor

Counter-suggestion: two groups of alphabetically sorted collaborators, those behind the security@ email, then those who aren't. (catering to both users searching for a contact & collaborators looking for reviewed-by emails)

@jbergstroem
Copy link
Member Author

@brendanashworth isn't all security email supposed to land in security@ anyway? (point being, we don't want people to be confused about where to send security related stuff)

@brendanashworth
Copy link
Contributor

@jbergstroem it should, but if someone is confused they may look down to the collaborator list and pick the first one they see. Probably not, but its just an idea.

jbergstroem added a commit that referenced this issue Sep 3, 2015
Fixes: #1972
PR-URL: #2322
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
@jbergstroem
Copy link
Member Author

Landed with #2322 (6ce8f5f)

jbergstroem added a commit that referenced this issue Sep 3, 2015
Fixes: #1972
PR-URL: #2322
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue Sep 3, 2015
Fixes: nodejs#1972
PR-URL: nodejs#2322
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
jbergstroem added a commit that referenced this issue Sep 6, 2015
Fixes: #1972
PR-URL: #2322
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
jbergstroem added a commit that referenced this issue Sep 6, 2015
Fixes: #1972
PR-URL: #2322
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
jbergstroem added a commit that referenced this issue Sep 6, 2015
Fixes: #1972
PR-URL: #2322
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
jbergstroem added a commit that referenced this issue Sep 6, 2015
Fixes: #1972
PR-URL: #2322
Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants