Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs,net: missing documentation for new "ready" events #19796

Closed
targos opened this issue Apr 4, 2018 · 2 comments
Closed

fs,net: missing documentation for new "ready" events #19796

targos opened this issue Apr 4, 2018 · 2 comments
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors. net Issues and PRs related to the net subsystem.

Comments

@targos
Copy link
Member

targos commented Apr 4, 2018

PR #19408 added new "ready" events to streams in fs and net.

I think they need to be documented and have a "changes" entry. The commit is going to be in the next v9.x release.
@targos targos added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. net Issues and PRs related to the net subsystem. labels Apr 4, 2018
@lpinca lpinca added the good first issue Issues that are suitable for first-time contributors. label Apr 6, 2018
@rajdhandus
Copy link
Contributor

@lpinca @targos - I would like to work on this item..

@towc towc mentioned this issue Apr 11, 2018
Closed
3 tasks
@towc
Copy link
Contributor

towc commented Apr 11, 2018

fixed in: #19935

@towc towc mentioned this issue Apr 12, 2018
Closed
3 tasks
jasnell pushed a commit that referenced this issue Apr 16, 2018
@towc @jasnell
doc: added ready events to fs/streams,net/socket
c29f2f2 
PR-URL: #19968
Fixes: #19796
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this issue May 1, 2018
@towc @BridgeAR
doc: added ready events to fs/streams,net/socket
eaf4a19 
PR-URL: nodejs#19968
Fixes: nodejs#19796
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. good first issue Issues that are suitable for first-time contributors. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
4 participants
@lpinca @targos @towc @rajdhandus