Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test/parallel/test-worker-message-port-transfer-closed.js #21892

Closed
Trott opened this issue Jul 19, 2018 · 2 comments
Closed
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support.

Comments

@Trott
Copy link
Member

Trott commented Jul 19, 2018

  • Version: 11.0.0-pre
  • Platform: freebsd10-64
  • Subsystem: test

https://ci.nodejs.org/job/node-test-commit-freebsd/19100/nodes=freebsd10-64/console

03:24:55 not ok 1993 parallel/test-worker-message-port-transfer-closed
03:24:55   ---
03:24:55   duration_ms: 4.999
03:24:55   severity: fail
03:24:55   exitcode: 1
03:24:55   stack: |-
03:24:55     assert.js:84
03:24:55       throw new AssertionError(obj);
03:24:55       ^
03:24:55     
03:24:55     AssertionError [ERR_ASSERTION]: The communication channel is still open at /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-worker-message-port-transfer-closed.js:53
03:24:55         at Timeout.mustNotCall [as _onTimeout] (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common/index.js:533:12)
03:24:55         at ontimeout (timers.js:454:11)
03:24:55         at tryOnTimeout (timers.js:326:5)
03:24:55         at listOnTimeout (timers.js:300:5)
03:24:55         at processTimers (timers.js:257:5)
03:24:55   ...
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support. labels Jul 19, 2018
@Trott
Copy link
Member Author

Trott commented Jul 19, 2018

The problem here is all but certainly the arbitrary-ish 1 second setTimeout() at the end of the test. FreeBSD is probably our CI platform most sensitive to race conditions in parallel. Moving this to sequential is the thing to do if the setTimeout() can't be removed or replaced with an event-based callback or something like that.

@Trott Trott changed the title Investigate flaky test/parallel/test-worker-message-port-transfer-closed. Investigate flaky test/parallel/test-worker-message-port-transfer-closed.js Jul 19, 2018
@Trott
Copy link
Member Author

Trott commented Jul 19, 2018

Stress test to hopefully confirm flakiness on master: https://ci.nodejs.org/job/node-stress-single-test/1967/nodes=freebsd10-64/console

Trott added a commit to Trott/io.js that referenced this issue Jul 23, 2018
Make test/parallel/test-worker-message-port-transfer-closed.js more
reliable by counting ticks rather than using a single setTimeout().

Fixes: nodejs#21892
@Trott Trott closed this as completed in f93a19b Jul 24, 2018
targos pushed a commit that referenced this issue Jul 26, 2018
Make test/parallel/test-worker-message-port-transfer-closed.js more
reliable by counting ticks rather than using a single setTimeout().

Fixes: #21892

PR-URL: #21893
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant