Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-net-connect-timeout #2469

Closed
joaocgreis opened this issue Aug 20, 2015 · 2 comments
Closed

Investigate flaky test test-net-connect-timeout #2469

joaocgreis opened this issue Aug 20, 2015 · 2 comments
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.

Comments

@joaocgreis
Copy link
Member

Examples of failures:
@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Aug 20, 2015
@Trott
Copy link
Member

Trott commented Aug 21, 2015

I believe #2257 would make this not-flaky.

EDIT: Although I suppose if internet tests are being run in CI, there's no need to move it to parallel the way that PR does. But that's an easy enough change I can make to it...

@Trott Trott mentioned this issue Aug 21, 2015
Closed
Trott added a commit that referenced this issue Aug 23, 2015
@Trott
test: use reserved IP in test-net-connect-timeout
ae8d436 
Use reserved IP in test-net-connect-timeout.js rather than arbitrary
IP.

PR-URL: #2257
Fixes: #2469
Reviewed By: Ben Noordhuis <[email protected]>
@Trott
Copy link
Member

Trott commented Aug 23, 2015

I believe this is fixed in #2257 / ae8d436

Guess we'll find out for sure after #2424 lands.

Closing because I think that's the right thing to do in this situation, but I don't feel strongly about that, so you know, re-open if you want it to stay open for a while.

@Trott Trott closed this as completed Aug 23, 2015
Trott added a commit that referenced this issue Aug 24, 2015
@Trott @rvagg
test: use reserved IP in test-net-connect-timeout
536c3d0 
Use reserved IP in test-net-connect-timeout.js rather than arbitrary
IP.

PR-URL: #2257
Fixes: #2469
Reviewed By: Ben Noordhuis <[email protected]>
@joaocgreis joaocgreis mentioned this issue Aug 25, 2015
Closed
This was referenced Aug 9, 2020
Open
Open
Open
Open
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaocgreis @Trott