Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker should indicate it inherits from EventEmitter #24732

Closed
arei opened this issue Nov 29, 2018 · 2 comments
Closed

Worker should indicate it inherits from EventEmitter #24732

arei opened this issue Nov 29, 2018 · 2 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@arei
Copy link

arei commented Nov 29, 2018

  • Version: 10..
  • Platform: Documentation
  • Subsystem: worker_threads

The documentation for Worker class should indicate that it inherits from EventEmitter. It's apparent that it does so reading the documentation, but it does not specifically say so. Other classes like ChildProcess do indicate this.

@lpinca lpinca added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Dec 3, 2018
@tuxedotu
Copy link

tuxedotu commented Dec 7, 2018

I could do that

@lpinca
Copy link
Member

lpinca commented Dec 11, 2018

Fixed by 9fc0b7b

@lpinca lpinca closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants