Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add class worker documentation #24849

Closed
wants to merge 2 commits into from

Conversation

yoshimoto8
Copy link
Contributor

This PR is repullrequest(#24809) because I did not read the document carefully and conflict occurred trying to fix. sorry, I am not used to git.

Add documentation about Worker class inherits from EventEmitter.

related #24732

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]

Add documentation about Worker class inherits from EventEmitter.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 5, 2018
@vsemozhetbyt vsemozhetbyt added the worker Issues and PRs related to Worker support. label Dec 5, 2018
I corrected the parts you pointed out.
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2018
@vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt
Copy link
Contributor

Landed in 9fc0b7b
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Dec 11, 2018
Add documentation about Worker class inherits from EventEmitter.

PR-URL: #24849
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
Add documentation about Worker class inherits from EventEmitter.

PR-URL: #24849
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Add documentation about Worker class inherits from EventEmitter.

PR-URL: nodejs#24849
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Add documentation about Worker class inherits from EventEmitter.

PR-URL: #24849
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Add documentation about Worker class inherits from EventEmitter.

PR-URL: #24849
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Add documentation about Worker class inherits from EventEmitter.

PR-URL: #24849
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants