can't pipe to a stream without listenerCount

[calvinmetcalf]

just noticed this when looking into upgrading readable stream to v3.3.0

[Fishrock123]

Was introduced in 8f58fb9. I'm on it.

[thefourtheye]

@calvinmetcalf Can you please explain with a small program to reproduce the problem?

[Fishrock123]

@calvinmetcalf I understand the gist of the issue, but I can't seem to reproduce it with this?

'use strict';
var common = require('../common');
var stream = require('stream');

const r = new stream.Stream();
r.listenerCount = undefined;

const w = new stream.Stream();
w.listenerCount = undefined;

w.on('pipe', function() {
  r.emit('error', new Error('Readable Error'));
  w.emit('error', new Error('Writable Error'));
});
r.pipe(w);

To my understanding that should cause this error?

EDIT: fixed.

[Fishrock123]

Does this only show up when using custom event-emitter solutions?

[thefourtheye]

@Fishrock123 You had to pipe it after attaching the handler ;-)

'use strict';
var stream = require('stream');

const r = new stream.Stream();
r.listenerCount = undefined;

const w = new stream.Stream();
w.listenerCount = undefined;

w.on('pipe', function() {
  r.emit('error', new Error('Readable Error'));
});

r.pipe(w);

Also, thanks for helping me understand the problem :-)

[Fishrock123]

Fixed in b513a33

@calvinmetcalf if you could confirm, that'd be 💯

[calvinmetcalf]

will look in the morning thanks!

[calvinmetcalf]

👍