Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tap file issues with test-ci #2834

Closed
lloydbenson opened this issue Sep 12, 2015 · 2 comments
Closed

tap file issues with test-ci #2834

lloydbenson opened this issue Sep 12, 2015 · 2 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@lloydbenson
Copy link

If I run make test-ci a resulting test.tap file gets created. If I run make test-ci again, rather than replacing that file, the file instead gets appended with new results. This leads to the tap file just continuing to grow with the same set of results. The expectation is that each new run would replace the tap file rather than append to it.

Related I would also expect a make clean to clean up the test result. Let me know if you would like that to be a separate issue.
@Fishrock123 Fishrock123 added the build Issues and PRs related to build files or the CI. label Sep 12, 2015
@bnoordhuis
Copy link
Member

/cc @nodejs/build

@thefourtheye thefourtheye mentioned this issue Sep 12, 2015
Closed
thefourtheye added a commit to thefourtheye/io.js that referenced this issue Sep 13, 2015
@thefourtheye
tools: open test.tap file in write-binary mode
43e809b 
By default the logfile is opened in append mode. This commit makes sure
that the file is opened in write-binary mode, so that the file will be
created if it doesn't exist or overwrite if it exists.

Fixes: nodejs#2834
thefourtheye added a commit to thefourtheye/io.js that referenced this issue Sep 13, 2015
@thefourtheye
build: clean up the generated tap file
89d5237 
Make `make clean` cleanup the generated tap file as well.

Fixes: nodejs#2834
lloydbenson referenced this issue in fishin/ficion Sep 13, 2015
@lloydbenson
do 0.10 now
e10f2fd
thefourtheye added a commit that referenced this issue Sep 15, 2015
@thefourtheye
tools: open test.tap file in write-binary mode
91e7e9c 
By default the logfile is opened in append mode. This commit makes sure
that the file is opened in write-binary mode, so that the file will be
created if it doesn't exist or overwrite if it exists.

Fixes: #2834

PR-URL: #2837
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
thefourtheye added a commit that referenced this issue Sep 15, 2015
@thefourtheye
build: clean up the generated tap file
467eff2 
Make `make clean` cleanup the generated tap file as well.

Fixes: #2834

PR-URL: #2837
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
@thefourtheye
Copy link
Contributor

Fixes landed in 91e7e9c and 467eff2. Thanks for reporting the problem :-)

thefourtheye added a commit that referenced this issue Sep 15, 2015
@thefourtheye @rvagg
tools: open test.tap file in write-binary mode
07fbf83 
By default the logfile is opened in append mode. This commit makes sure
that the file is opened in write-binary mode, so that the file will be
created if it doesn't exist or overwrite if it exists.

Fixes: #2834

PR-URL: #2837
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
thefourtheye added a commit that referenced this issue Sep 15, 2015
@thefourtheye @rvagg
build: clean up the generated tap file
574475d 
Make `make clean` cleanup the generated tap file as well.

Fixes: #2834

PR-URL: #2837
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
thefourtheye added a commit that referenced this issue Sep 15, 2015
@thefourtheye @Fishrock123
tools: open test.tap file in write-binary mode
69e7b87 
By default the logfile is opened in append mode. This commit makes sure
that the file is opened in write-binary mode, so that the file will be
created if it doesn't exist or overwrite if it exists.

Fixes: #2834

PR-URL: #2837
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
thefourtheye added a commit that referenced this issue Sep 15, 2015
@thefourtheye @Fishrock123
build: clean up the generated tap file
e35b1fd 
Make `make clean` cleanup the generated tap file as well.

Fixes: #2834

PR-URL: #2837
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bnoordhuis @thefourtheye @Fishrock123 @lloydbenson