Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented options for child_process.exec and execSync? #3387

Closed
joliss opened this issue Oct 15, 2015 · 2 comments
Closed

Undocumented options for child_process.exec and execSync? #3387

joliss opened this issue Oct 15, 2015 · 2 comments
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@joliss
Copy link
Contributor

joliss commented Oct 15, 2015

I assume that exec and execSync have the same set of options, but in the documentation some are missing:

The shell option mentioned in child_process.exec is absent from the execSync documentation.

Conversely, the input and stdio options mentioned in child_process.execSync are absent from the exec documentation. Edit: Hm, I'm not sure if these are actually supported by exec. Strange.
@Trott
Copy link
Member

Trott commented Oct 15, 2015

The shell one is definitely an oversight. That should be there.

@Trott Trott added good first issue Issues that are suitable for first-time contributors. doc Issues and PRs related to the documentations. labels Oct 15, 2015
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Oct 15, 2015
@claudiorodriguez
Copy link
Contributor

Working on it. Does this also apply to execFileSync (going by the args normalization, it doesn't, but just in case)?

@claudiorodriguez claudiorodriguez mentioned this issue Oct 19, 2015
Closed
rvagg pushed a commit that referenced this issue Oct 21, 2015
@rvagg
docs: add missing shell option to execSync
47b06f6 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #3440
jasnell pushed a commit that referenced this issue Oct 26, 2015
@jasnell
docs: add missing shell option to execSync
47ab7c7 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #3440
jasnell pushed a commit that referenced this issue Oct 29, 2015
@jasnell
docs: add missing shell option to execSync
9120a04 
Adds the "shell" option from child_process.exec to
child_process.execSync on the api docs.

Fixes: #3387
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #3440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @joliss @Trott @claudiorodriguez