-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http2ServerRequest#setTimeout
should return this
#33993
Comments
rexagod
changed the title
Jun 20, 2020
http2.Http2ServerRequest.connection.setTimeout
should return this
instead of void
/undefined
http2.Http2ServerRequest.setTimeout
should return this
instead of void
/undefined
rexagod
changed the title
Jun 20, 2020
http2.Http2ServerRequest.setTimeout
should return this
instead of void
/undefined
Http2ServerRequest#setTimeout
should return this
rexagod
added a commit
to rexagod/node
that referenced
this issue
Jun 20, 2020
2 tasks
This was referenced Jun 23, 2020
13 tasks
codebytere
pushed a commit
that referenced
this issue
Jun 27, 2020
Fixes: #33993 PR-URL: #33994 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
codebytere
pushed a commit
that referenced
this issue
Jun 30, 2020
Fixes: #33993 PR-URL: #33994 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
Fixes: #33993 PR-URL: #33994 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
http2.Http2ServerRequest.setTimeout
should returnthis
instead ofvoid
/undefined
It's the last thing in the TypeScript typings to fix:
See:
node/lib/_http_incoming.js
Line 100 in 4678e44
node/lib/internal/http2/compat.js
Line 416 in 4678e44
Originally posted by @clshortfuse in #29829 (comment)
The text was updated successfully, but these errors were encountered: