Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol.toStringTag is missing in buffer.Blob #37337

Closed
jimmywarting opened this issue Feb 12, 2021 · 1 comment · Fixed by #37336
Closed

Symbol.toStringTag is missing in buffer.Blob #37337

jimmywarting opened this issue Feb 12, 2021 · 1 comment · Fixed by #37336

Comments

@jimmywarting
Copy link

  • Version: v15.8.0
  • Platform: Darwin Kernel Version 20.1.0: Sat Oct 31 00:07:11 PDT 2020; root:xnu-7195.50.7~2/RELEASE_X86_64 x86_64
  • Subsystem:

Thought I would try it out and help you find some quirks before making Blob more stable.
Symbol.toStringTag is missing, That is what we use to check wether or not the input is a Blob or not.

What steps will reproduce the bug?

import { Blob } from 'buffer'

new Blob()[Symbol.toStringTag]

How often does it reproduce?

Happens everytime

What is the expected behavior?

To get a string that equals to "Blob"

What do you see instead?

undefined

This should not happen.
@cjihrig
Copy link
Contributor

cjihrig commented Feb 12, 2021

Proposed fix in #37336

@jimmywarting jimmywarting mentioned this issue Feb 12, 2021
Closed
5 tasks
@aduh95 aduh95 mentioned this issue Feb 13, 2021
Merged
danielleadams pushed a commit that referenced this issue Feb 16, 2021
@cjihrig @danielleadams
buffer: add @@toStringTag to Blob
c160d88 
This commit adds the toStringTag to the Blob class to match
the behavior of Chrome and Firefox.

PR-URL: #37336
Fixes: #37337
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this issue Aug 8, 2021
@cjihrig @targos
buffer: add @@toStringTag to Blob
b2bcd51 
This commit adds the toStringTag to the Blob class to match
the behavior of Chrome and Firefox.

PR-URL: nodejs#37336
Fixes: nodejs#37337
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this issue Aug 8, 2021
@cjihrig @targos
buffer: add @@toStringTag to Blob
54522c8 
This commit adds the toStringTag to the Blob class to match
the behavior of Chrome and Firefox.

PR-URL: nodejs#37336
Fixes: nodejs#37337
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit to targos/node that referenced this issue Aug 13, 2021
@cjihrig @targos
buffer: add @@toStringTag to Blob
bb0c918 
This commit adds the toStringTag to the Blob class to match
the behavior of Chrome and Firefox.

PR-URL: nodejs#37336
Fixes: nodejs#37337
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this issue Aug 13, 2021
@cjihrig @targos
buffer: add @@toStringTag to Blob
be194d1 
This commit adds the toStringTag to the Blob class to match
the behavior of Chrome and Firefox.

PR-URL: #37336
Backport-PR-URL: #39704
Fixes: #37337
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Aug 31, 2021
@cjihrig @MylesBorins
buffer: add @@toStringTag to Blob
e7cf2ef 
This commit adds the toStringTag to the Blob class to match
the behavior of Chrome and Firefox.

PR-URL: #37336
Backport-PR-URL: #39704
Fixes: #37337
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
foxxyz pushed a commit to foxxyz/node that referenced this issue Oct 18, 2021
@cjihrig @foxxyz
buffer: add @@toStringTag to Blob
d573bea 
This commit adds the toStringTag to the Blob class to match
the behavior of Chrome and Firefox.

PR-URL: nodejs#37336
Backport-PR-URL: nodejs#39704
Fixes: nodejs#37337
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

buffer: add @@toStringTag to Blob cjihrig/node
2 participants
@jimmywarting @cjihrig