Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-http-chunked-304 on SmartOS #3864

Closed
Trott opened this issue Nov 16, 2015 · 1 comment
Closed

Investigate flaky test test-http-chunked-304 on SmartOS #3864

Trott opened this issue Nov 16, 2015 · 1 comment
Labels
http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Nov 16, 2015

Fails about 0.03% of the time. Looks similar to #3830 and a similar fix may be in order.

https://ci.nodejs.org/job/node-stress-single-test/3/nodes=smartos14-32/console
@Trott Trott added test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Nov 16, 2015
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 16, 2015
@claudiorodriguez claudiorodriguez mentioned this issue Nov 18, 2015
Closed
@claudiorodriguez
Copy link
Contributor

@Trott Would appreciate your feedback on the PR. I hope you don't mind I more or less cloned your commit message and code comment.
Gotta say I'm a bit iffy on those listeners being bound inside the 'connect' listener - that's how I found it so I went for consistency. I can of course extract them if it could be an issue.

claudiorodriguez pushed a commit to claudiorodriguez/node that referenced this issue Nov 19, 2015
test: fix flaky http-chunked-304 on smartos
89d67c3 
SmartOS has an issue where it will trigger ECONNREFUSED when it
should not. See https://smartos.org/bugview/OS-2767.

This change adds logic to test-http-chunked-304 to work around
the issue. See also similar issue: nodejs#2663

Fixes: nodejs#3864
@Trott Trott mentioned this issue Nov 20, 2015
Closed
Trott added a commit to Trott/io.js that referenced this issue Nov 20, 2015
@Trott
test: retry on smartos if ECONNREFUSED
c5eed86 
SmartOS has a bug that causes unexpected ECONNREFUSED errors.

See https://smartos.org/bugview/OS-2767

If ECONNREFUSED on SmartOS, retry the test one time.

Fixes: nodejs#3864
Fixes: nodejs#2815
PR-URL: nodejs#3941
Trott added a commit to Trott/io.js that referenced this issue Nov 21, 2015
@Trott
test: retry on smartos if ECONNREFUSED
dcac25b 
SmartOS has a bug that causes unexpected ECONNREFUSED errors.

See https://smartos.org/bugview/OS-2767

If ECONNREFUSED on SmartOS, retry the test one time.

Fixes: nodejs#3864
Fixes: nodejs#2815
PR-URL: nodejs#3941
@Trott Trott closed this as completed in 8bc8038 Nov 23, 2015
Trott added a commit that referenced this issue Dec 1, 2015
@Trott
test: retry on smartos if ECONNREFUSED
9bc9a2b 
SmartOS has a bug that causes unexpected ECONNREFUSED errors.

See https://smartos.org/bugview/OS-2767

If ECONNREFUSED on SmartOS, retry the test one time.

Fixes: #3864
Fixes: #2815
PR-URL: #3941
Reviewed-By: Fedor Indutny <[email protected]>
Trott added a commit that referenced this issue Dec 4, 2015
@Trott @rvagg
test: retry on smartos if ECONNREFUSED
e2dee8d 
SmartOS has a bug that causes unexpected ECONNREFUSED errors.

See https://smartos.org/bugview/OS-2767

If ECONNREFUSED on SmartOS, retry the test one time.

Fixes: #3864
Fixes: #2815
PR-URL: #3941
Reviewed-By: Fedor Indutny <[email protected]>
Trott added a commit that referenced this issue Dec 5, 2015
@Trott @rvagg
test: retry on smartos if ECONNREFUSED
1fe4d30 
SmartOS has a bug that causes unexpected ECONNREFUSED errors.

See https://smartos.org/bugview/OS-2767

If ECONNREFUSED on SmartOS, retry the test one time.

Fixes: #3864
Fixes: #2815
PR-URL: #3941
Reviewed-By: Fedor Indutny <[email protected]>
Trott added a commit that referenced this issue Dec 17, 2015
@Trott @jasnell
test: retry on smartos if ECONNREFUSED
5a27274 
SmartOS has a bug that causes unexpected ECONNREFUSED errors.

See https://smartos.org/bugview/OS-2767

If ECONNREFUSED on SmartOS, retry the test one time.

Fixes: #3864
Fixes: #2815
PR-URL: #3941
Reviewed-By: Fedor Indutny <[email protected]>
Trott added a commit that referenced this issue Dec 23, 2015
@Trott @jasnell
test: retry on smartos if ECONNREFUSED
ff2266a 
SmartOS has a bug that causes unexpected ECONNREFUSED errors.

See https://smartos.org/bugview/OS-2767

If ECONNREFUSED on SmartOS, retry the test one time.

Fixes: #3864
Fixes: #2815
PR-URL: #3941
Reviewed-By: Fedor Indutny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @Trott @claudiorodriguez