Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-net-connect-options-ipv6 #4200

Closed
Trott opened this issue Dec 8, 2015 · 6 comments
Closed

Investigate flaky test-net-connect-options-ipv6 #4200

Trott opened this issue Dec 8, 2015 · 6 comments
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Dec 8, 2015

Failure in CI:

@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Dec 8, 2015
@Trott
Copy link
Member Author

Trott commented Dec 9, 2015

@evanlucas
Copy link
Contributor

Trott added a commit to Trott/io.js that referenced this issue Dec 23, 2015
@Trott
Copy link
Member Author

Trott commented Dec 23, 2015

The way the test retries 10 times if it receives this error seems to suggest a prior attempt to work around the flakiness...

Stress tests are not (so far) reproducing the problem:

Doesn't seem to be a FIPS mode for the stress test job. (/cc @joaocgreis for confirmation)

@Trott
Copy link
Member Author

Trott commented Dec 23, 2015

The way the test retries 10 times if it receives this error seems to suggest a prior attempt to work around the flakiness...

Oh, hey, that was a very recent change by @mscdex. #4325

Seems to be a fix for exactly this issue. Closing!

@Trott Trott closed this as completed Dec 23, 2015
@joaocgreis
Copy link
Member

@Trott
Copy link
Member Author

Trott commented Dec 23, 2015

@joaocgreis Hooray, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants