Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build break: Failed to generate license.rtf #43213

Closed
richardlau opened this issue May 26, 2022 · 5 comments · Fixed by #43214
Closed

Windows build break: Failed to generate license.rtf #43213

richardlau opened this issue May 26, 2022 · 5 comments · Fixed by #43214
Labels
windows Issues and PRs related to the Windows platform.

Comments

@richardlau
Copy link
Member

richardlau commented May 26, 2022

Version

nightly

Platform

Windows

Subsystem

No response

What steps will reproduce the bug?

Windows CI builds are failing.

How often does it reproduce? Is there a required condition?

Today's daily master build and a number of CI's for pull requests.

What is the expected behavior?

Build completes.

What do you see instead?

Build fails. e.g. https://ci.nodejs.org/job/node-compile-windows/45207/nodes=win-vs2019/console

08:23:37 )  
08:23:37  tools\license2rtf.mjs  0<LICENSE 1>Release\license.rtf 
08:23:37 )  else (Release\node.exe tools\license2rtf.mjs  0<LICENSE 1>Release\license.rtf ) 
08:23:37 
08:23:37 > if errorlevel 1 echo Failed to generate license.rtf  & goto exit 
08:23:37 Failed to generate license.rtf
08:23:37 
08:23:37 > if 13 NEQ 0 exit /b 13 
08:23:37 
08:23:37 > if errorlevel 1 exit /b 
08:23:37 
08:23:37 > if errorlevel 1 exit /b 
08:23:37 
08:23:37 > if errorlevel 1 exit /b 
08:23:37 
08:23:37 > if errorlevel 1 exit /b 
08:23:37 Build step 'Execute Windows batch command' marked build as failure

Additional information

#43101 landed yesterday and looks very relevant. That passed its CI but maybe something else has landed that when combined causes the break?

cc @nodejs/platform-win

@richardlau richardlau added the windows Issues and PRs related to the Windows platform. label May 26, 2022
@richardlau
Copy link
Member Author

#43101 landed yesterday and looks very relevant. That passed its CI but maybe something else has landed that when combined causes the break?

Actually scratch that, the last CI for that PR was broken: https://ci.nodejs.org/job/node-test-pull-request/44161/. I'll open a revert.

@richardlau
Copy link
Member Author

Revert PR: #43214

nodejs-github-bot pushed a commit that referenced this issue May 26, 2022
This reverts commit 30cb1bf.

PR-URL: #43214
Fixes: #43213
Refs: #43101
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@F3n67u
Copy link
Member

F3n67u commented May 28, 2022

@richardlau do you have any idea why the windows build failed? I am not familiar with Nodejs Jenkins pipeline and windows stuff.

@richardlau
Copy link
Member Author

No I do not. There wasn't any further error messages to indicate why.

@F3n67u
Copy link
Member

F3n67u commented May 29, 2022

@richardlau I found the reason why #43101 will cause windows build break. I made a pr: #43232, please take a look.

danielleadams pushed a commit that referenced this issue Jun 11, 2022
This reverts commit 30cb1bf.

PR-URL: #43214
Fixes: #43213
Refs: #43101
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
LiviaMedeiros pushed a commit that referenced this issue Jul 7, 2022
This reverts commit 331088f.

PR-URL: #43232
Refs: #43213
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this issue Jul 12, 2022
This reverts commit 331088f.

PR-URL: #43232
Refs: #43213
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this issue Jul 20, 2022
This reverts commit 331088f.

PR-URL: #43232
Refs: #43213
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this issue Jul 31, 2022
This reverts commit 331088f.

PR-URL: #43232
Refs: #43213
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
This reverts commit 331088f.

PR-URL: nodejs/node#43232
Refs: nodejs/node#43213
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants