Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL 3.x build error #43667

Closed
RafaelGSS opened this issue Jul 3, 2022 · 0 comments
Closed

OpenSSL 3.x build error #43667

RafaelGSS opened this issue Jul 3, 2022 · 0 comments
Labels
build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency.

Comments

@RafaelGSS
Copy link
Member

We're experiencing a few problems in the OpenSSL 3.x update

References:

  1. deps: update OpenSSL 3.0.4+quic #43589 (comment)
    That was partially solved by a simple:
+ # deps/openssl/config/Makefile
+ clean-s:
+	find archs \( -name \*.s \) -exec rm "{}" \

Will need to adjust the document https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-openssl.md to prevent similar issues.

  1. 32-bit Windows is failing to compile deps: update OpenSSL 3.0.4+quic #43603
@VoltrexKeyva VoltrexKeyva added build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. labels Jul 3, 2022
@RafaelGSS RafaelGSS mentioned this issue Jul 8, 2022
Closed
RafaelGSS added a commit that referenced this issue Jul 15, 2022
@RafaelGSS
deps: clean archs files for OpenSSL
3f0db60 
 After an OpenSSL source update, all the config files need to be
 regenerated and committed by:
    $ make -C deps/openssl/config clean
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git commit

PR-URL: #43735
Fixes: #43667
Reviewed-By: Richard Lau <[email protected]>
RafaelGSS added a commit that referenced this issue Jul 15, 2022
@RafaelGSS
doc: include make clean to openssl arch
6d7087e 
PR-URL: #43735
Fixes: #43667
Reviewed-By: Richard Lau <[email protected]>
@RafaelGSS RafaelGSS mentioned this issue Jul 15, 2022
Closed
danielleadams pushed a commit that referenced this issue Jul 26, 2022
@RafaelGSS @danielleadams
deps: remove not used architectures
fc936a8 
PR-URL: #43735
Fixes: #43667
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this issue Jul 26, 2022
@RafaelGSS @danielleadams
deps: clean archs files for OpenSSL
cdff619 
 After an OpenSSL source update, all the config files need to be
 regenerated and committed by:
    $ make -C deps/openssl/config clean
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git commit

PR-URL: #43735
Fixes: #43667
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this issue Jul 26, 2022
@RafaelGSS @danielleadams
doc: include make clean to openssl arch
ec7e45e 
PR-URL: #43735
Fixes: #43667
Reviewed-By: Richard Lau <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@RafaelGSS @Fyko
deps: remove not used architectures
279723c 
PR-URL: nodejs#43735
Fixes: nodejs#43667
Reviewed-By: Richard Lau <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@RafaelGSS @Fyko
deps: clean archs files for OpenSSL
6937f01 
 After an OpenSSL source update, all the config files need to be
 regenerated and committed by:
    $ make -C deps/openssl/config clean
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git commit

PR-URL: nodejs#43735
Fixes: nodejs#43667
Reviewed-By: Richard Lau <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@RafaelGSS @Fyko
doc: include make clean to openssl arch
b19b871 
PR-URL: nodejs#43735
Fixes: nodejs#43667
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: update openssl arch reference RafaelGSS/node
2 participants
@RafaelGSS @VoltrexKeyva