Small ICU fails to build #45174
Comments
|
I would only be able to revert the ICU update. I don't know how to fix it. |
|
@nodejs/i18n-api |
|
bisecting ICU to see what broke. Even old node versions (Gallium something) would fail to build icu 72 |
|
can someone suggest a way to speed up the build to just build the failing .o file? |
maybe |
|
OK bisect says that its icu commit |
Maybe we need to extend enabling rtti to the other ICU targets? node/tools/icu/icu-generic.gyp Lines 51 to 65 in 5fad0b9 It's currently set for icu_implementation but I think the failure has occured in genrb.
|
@richardlau i think you are right. |
|
@richardlau could you try patching? |
|
@richardlau except that icutools already depends on icu_implementation node/tools/icu/icu-generic.gyp Line 369 in 5fad0b9 |
|
PTAL #45195 |
- RTTI is needed for genrb now Fixes: nodejs#45174
|
the ICU PR was unicode-org/icu#2118 |
- RTTI is needed for genrb now. Fixes: #45174 PR-URL: #45195 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- RTTI is needed for genrb now. Fixes: #45174 PR-URL: #45195 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- RTTI is needed for genrb now. Fixes: #45174 PR-URL: #45195 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- RTTI is needed for genrb now. Fixes: #45174 PR-URL: #45195 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- RTTI is needed for genrb now. Fixes: #45174 PR-URL: #45195 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
- RTTI is needed for genrb now. Fixes: #45174 PR-URL: #45195 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Version
mainPlatform
macOS
Subsystem
build
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior?
No response
What do you see instead?
Additional information
Switching to
--without-intlor full ICU fixes the issue. I'll try bisecting to see when this was introduced but I suspect it's the recent ICU update.The text was updated successfully, but these errors were encountered: