-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node --test does not show skipped tests in TAP result #45833
Comments
When you run with Since Node v19.2.0, the output is combined more intelligently. Now that we have the other pieces in place, I think we should go a step further now and remove the separation by test file in the output. In other words, if file 1 had 3 top level tests, and file 2 had 4 top level tests, then the output from |
But what about the case when I have only one file? The result is the same - all tests passed and no information about skipped tests. Does it mean that |
What I'm proposing in #45833 (comment) would apply to the case where there is a single file. The summary printed at the end of a run only applies to top level tests. If you run without I think you already realize this based on your original bug report, but if you only have one file, then as a workaround for now, you can run without |
cc @manekinekko in case you have any interest in working on this ^ - I think the changes would be confined to the CLI runner and parser. |
PR-URL: #46440 Fixes: #45833 Refs: #45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#46440 Fixes: nodejs#45833 Refs: nodejs#45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#46440 Fixes: nodejs#45833 Refs: nodejs#45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#46440 Fixes: nodejs#45833 Refs: nodejs#45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#46440 Fixes: nodejs#45833 Refs: nodejs#45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#46440 Fixes: nodejs#45833 Refs: nodejs#45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#46440 Fixes: nodejs#45833 Refs: nodejs#45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #46440 Backport-PR-URL: #46839 Fixes: #45833 Refs: #45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #46440 Backport-PR-URL: #46839 Fixes: #45833 Refs: #45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #46440 Fixes: #45833 Refs: #45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #46440 Fixes: #45833 Refs: #45833 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Version
v18.12.1
Platform
Darwin Kernel Version 22.1.0 root:xnu-8792.41.9~2/RELEASE_ARM64_T8103 arm64
Subsystem
node:test
What steps will reproduce the bug?
In my project I have a folder named 'test' with two files inside.
The first file (Unit one) contains describe and test with different variations of skip. All the asserts are intentionally failed.
The second file contains describe and test with correct asserts (Unit two).
Additionally, if I have the only file with combination of both skipped and ordinary describe and test (Unit three). This file was run separately.
How often does it reproduce? Is there a required condition?
Every time when I use
node --test
What is the expected behavior?
When I run
node --test
, I expect to see information about skipped tests in the final TAP result.What do you see instead?
When I run
node --test
with 'test' folder, contains of the first and the second files, there are no skipped tests.When I run the third file alone I have the same result without skipped tests as well
Additional information
On the contrary, if I run
node test/one.mjs
I have correct TAP result with information about skipped tests.As well as I run
node test/three.mjs
The text was updated successfully, but these errors were encountered: