Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows - UNC Path Support via npm.ps1 #48471

Closed
mribbons opened this issue Jun 16, 2023 · 5 comments · Fixed by #52009
Closed

Windows - UNC Path Support via npm.ps1 #48471

mribbons opened this issue Jun 16, 2023 · 5 comments · Fixed by #52009
Labels
feature request Issues that request new features to be added to Node.js. npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform.

Comments

@mribbons
Copy link

What is the problem this feature will solve?

npm.cmd fails on Windows in UNC (And WSL) paths, because cmd.exe doesn't support UNC paths as cwd:
npm/cli#6280

What is the feature you are proposing to solve the problem?

This PR partially resolves the problem, but we need more info, as requested by @lukekarrys:

npm/cli#6548

Would you be able to open an issue or PR on https://github.com/nodejs/node to get feedback on how the Windows installers work, and if it would be appropriate for npm to ship these ps1 scripts in our bin/ dir and have them picked up by the installer?

What alternatives have you considered?

No response
@mribbons mribbons added the feature request Issues that request new features to be added to Node.js. label Jun 16, 2023
@mribbons mribbons mentioned this issue Jun 16, 2023
Merged
@tniessen tniessen added windows Issues and PRs related to the Windows platform. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jun 19, 2023
@lukekarrys
Copy link
Member

The npm CLI is almost ready to ship PowerShell scripts (ref: npm/cli#6548). When npm ships these, the Node Windows installer should be updated to place those along with the existing *.cmd files.

My question is how can we ensure that the Windows installer works whether or not the *.ps1 files are present? It would be nice if the commits updating npm and making the Windows installer place the PowerShell scripts didn't need to land at the same time.

lukekarrys added a commit to lukekarrys/node that referenced this issue Jun 24, 2023
@lukekarrys
tools: install npm PowerShell scripts on Windows
caacd22 
npm has PowerShell scripts that should be installed alongside the cmd
and shell scripts on Windows. The PoweShell scripts should only be placed
if they exist in npm's bin directory.

Closes: nodejs#48471
Ref: npm/cli#6548
@bnoordhuis
Copy link
Member

My question is how can we ensure that the Windows installer works whether or not the *.ps1 files are present?

https://wixtoolset.org/docs/v3/xsd/wix/file/ - I think the answer is "you can't."

@lukekarrys
Copy link
Member

https://wixtoolset.org/docs/v3/xsd/wix/file/ - I think the answer is "you can't."

If that's that case, then here is my plan:

I'll hold off on my Node PR until the scripts have officially landed in npm and that version of npm has landed in Node.

Once I do make the Node PR, I'll label it appropriately to indicate that it shouldn't be backported to any Node version that doesn't contain the *.ps1 scripts.

@github-actions GitHub Actions
Copy link
Contributor

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Dec 22, 2023
@mribbons
Copy link
Author

keep-alive

@github-actions github-actions bot removed the stale label Dec 23, 2023
lukekarrys added a commit that referenced this issue Mar 7, 2024
@lukekarrys
tools: install npm PowerShell scripts on Windows
2deeddc 
npm 9.8.0 added PowerShell scripts that should be installed alongside
the cmd and shell scripts on Windows.

Closes: #48471
Ref: npm/cli#6548
lukekarrys added a commit that referenced this issue Mar 7, 2024
@lukekarrys
tools: install npm PowerShell scripts on Windows
42d18ba 
npm 9.8.0 added PowerShell scripts that should be installed alongside
the cmd and shell scripts on Windows.

Fixes: #48471
Refs: npm/cli#6548
@lukekarrys lukekarrys mentioned this issue Mar 7, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue Mar 27, 2024
@lukekarrys
tools: install npm PowerShell scripts on Windows
4d86020 
npm 9.8.0 added PowerShell scripts that should be installed alongside
the cmd and shell scripts on Windows.

Fixes: #48471
Refs: npm/cli#6548
PR-URL: #52009
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this issue May 2, 2024
@lukekarrys @marco-ippolito
tools: install npm PowerShell scripts on Windows
e7b9ef2 
npm 9.8.0 added PowerShell scripts that should be installed alongside
the cmd and shell scripts on Windows.

Fixes: #48471
Refs: npm/cli#6548
PR-URL: #52009
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this issue May 3, 2024
@lukekarrys @marco-ippolito
tools: install npm PowerShell scripts on Windows
c39f15c 
npm 9.8.0 added PowerShell scripts that should be installed alongside
the cmd and shell scripts on Windows.

Fixes: #48471
Refs: npm/cli#6548
PR-URL: #52009
Reviewed-By: Luigi Pinca <[email protected]>
@RedYetiDev RedYetiDev moved this from Awaiting Triage to Done in Node.js feature requests Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: install npm PowerShell scripts on Windows nodejs/node
4 participants
@bnoordhuis @lukekarrys @mribbons @tniessen