test-structuredclone-jstransferable is flaky

[anonrig]

Test

test-structuredclone-jstransferable

Platform

Windows

Console output

not ok 922 pummel/test-structuredclone-jstransferable
  ---
  duration_ms: 2662.02700
  severity: fail
  exitcode: 134
  stack: |-
    Administrator: 5680[4512]: C:\workspace\node-compile-windows\node\src\histogram.cc:29: Assertion `(0) == (hdr_init(options.lowest, options.highest, options.figures, &histogram))'

Build links

• https://ci.nodejs.org/job/node-test-binary-windows-js-suites/23930/

Additional information

No response

[H4ad]

@legendecas Maybe this one is interesting to you.

14:25:05  failed 2 out of 10
14:25:05 not ok 922 pummel/test-structuredclone-jstransferable
14:25:05   ---
14:25:05   duration_ms: 2662.02700
14:25:05   severity: fail
14:25:05   exitcode: 134
14:25:05   stack: |-
14:25:05     Administrator: 5680[4512]: C:\workspace\node-compile-windows\node\src\histogram.cc:29: Assertion `(0) == (hdr_init(options.lowest, options.highest, options.figures, &histogram))' failed.

Failing at:

node/src/histogram.cc

Lines 24 to 31 in e0bbe56

	Histogram::Histogram(const Options& options) {
	hdr_histogram* histogram;
	CHECK_EQ(0, hdr_init(options.lowest,
	options.highest,
	options.figures,
	&histogram));
	histogram_.reset(histogram);
	}

[StefanStojanovic]

Hey all, I haven't seen this test flaking for some time, so I've run stress test (1000 runs) on it and there were no failures. Is this proof enough that we can remove the flaky mark from it (I'll open a PR after getting a confirmation here), or should something else be done to validate that it is no longer flaky (e.g. more runs in the stress test, or something else)?