Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf_hooks] There are no 'net' and 'dns' in performanceEntry.entryType doc. #50290

Closed
Semigradsky opened this issue Oct 19, 2023 · 2 comments · Fixed by #54263
Closed

[perf_hooks] There are no 'net' and 'dns' in performanceEntry.entryType doc. #50290

Semigradsky opened this issue Oct 19, 2023 · 2 comments · Fixed by #54263
Labels
doc Issues and PRs related to the documentations.

Comments

@Semigradsky
Copy link
Contributor

Affected URL(s)

https://nodejs.org/docs/latest-v20.x/api/perf_hooks.html#performanceentryentrytype

Description of the problem

There are no 'net' and 'dns' in performanceEntry.entryType doc. But they exist in examples:
https://nodejs.org/docs/latest-v20.x/api/perf_hooks.html#measuring-how-long-the-netconnect-only-for-tcp-takes-when-the-connection-is-successful
and
https://nodejs.org/docs/latest-v20.x/api/perf_hooks.html#measuring-how-long-the-dns-takes-when-the-request-is-successful
@Semigradsky Semigradsky added the doc Issues and PRs related to the documentations. label Oct 19, 2023
@Semigradsky Semigradsky mentioned this issue Oct 19, 2023
Merged
7 tasks
@kineticstorytelling
Copy link

Hello, is it alright if I do a pr for this one as my first issue?

@Semigradsky
Copy link
Contributor Author

Semigradsky commented Oct 21, 2023 •
edited
Loading

PR already exists, see linked

UPD: @kineticstorytelling Sorry, I сonfused this ticket with another

@Semigradsky Semigradsky mentioned this issue Aug 6, 2024
Closed
@jazelly jazelly mentioned this issue Aug 8, 2024
Merged
jazelly added a commit to jazelly/node that referenced this issue Aug 9, 2024
@jazelly
doc: correct peformance entry types
31d4f56 
Fixes: nodejs#54212
Fixes: nodejs#50290
jazelly added a commit to jazelly/node that referenced this issue Aug 9, 2024
@jazelly
doc: correct peformance entry types
0dabfa0 
Fixes: nodejs#54212
Fixes: nodejs#50290
RafaelGSS pushed a commit that referenced this issue Aug 19, 2024
@jazelly @RafaelGSS
doc: correct peformance entry types
814cb80 
Fixes: #54212
Fixes: #50290
PR-URL: #54263
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this issue Aug 21, 2024
@jazelly @RafaelGSS
doc: correct peformance entry types
aa6e770 
Fixes: #54212
Fixes: #50290
PR-URL: #54263
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: correct peformance entry types jazelly/node
2 participants
@Semigradsky @kineticstorytelling