Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aarch64 and arm64 inconsistencies #5175

Closed
jbergstroem opened this issue Feb 10, 2016 · 2 comments
Closed

aarch64 and arm64 inconsistencies #5175

jbergstroem opened this issue Feb 10, 2016 · 2 comments
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI.

Comments

@jbergstroem
Copy link
Member

./configure currently sets host/target_arch as arm64 whereas Makefile will treat it as aarch64 (uname -s doesn't match anything). Suggesting we give Makefile a similar treatment?

/cc @nodejs/build
@jbergstroem jbergstroem added the build Issues and PRs related to build files or the CI. label Feb 10, 2016
@rvagg
Copy link
Member

rvagg commented Feb 10, 2016

I don't mind unifying it a little like we do for x86/ia32 (although even there we're not fully unified thanks mainly to gyp).

@jbergstroem as an aside: both ARCH and DESTCPU are passed for the iojs+release Jenkins job which is why we need to have them explicitly set on the release machines, otherwise it comes out as ARCH="" DESTCPU="" and in Makefile that's read as those variables being set and not up for auto detection. xgene-3 missing both of these env vars lead to failure because Jenkins is configured to use them (which I prefer fwiw).

@jbergstroem
Copy link
Member Author

@rvagg I would personally prefer using them only if set so we can fall back on defaults but don't have a strong opinion about it. Don't break what works (like I did last time), I guess.

@mscdex mscdex added the arm Issues and PRs related to the ARM platform. label Feb 10, 2016
@jbergstroem jbergstroem mentioned this issue Feb 11, 2016
Merged
rvagg pushed a commit that referenced this issue Feb 15, 2016
@jbergstroem @rvagg
build: treat aarch64 as arm64
356acb3 
`Makefile` is now consistent with `configure` regarding
how we treat aarch64.

PR-URL: #5191
Fixes: #5175
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
stefanmb pushed a commit to stefanmb/node that referenced this issue Feb 23, 2016
@jbergstroem @stefanmb
build: treat aarch64 as arm64
1ae8d9b 
`Makefile` is now consistent with `configure` regarding
how we treat aarch64.

PR-URL: nodejs#5191
Fixes: nodejs#5175
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 1, 2016
@jbergstroem
build: treat aarch64 as arm64
c16e800 
`Makefile` is now consistent with `configure` regarding
how we treat aarch64.

PR-URL: #5191
Fixes: #5175
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 1, 2016
@jbergstroem
build: treat aarch64 as arm64
4a6e2b2 
`Makefile` is now consistent with `configure` regarding
how we treat aarch64.

PR-URL: #5191
Fixes: #5175
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this issue Mar 2, 2016
@jbergstroem
build: treat aarch64 as arm64
a8e776f 
`Makefile` is now consistent with `configure` regarding
how we treat aarch64.

PR-URL: #5191
Fixes: #5175
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@richardlau richardlau mentioned this issue Aug 29, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @jbergstroem @rvagg