Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky GC-related tests with V8 12.2 #52273

Open
targos opened this issue Mar 30, 2024 · 4 comments
Open

Flaky GC-related tests with V8 12.2 #52273

targos opened this issue Mar 30, 2024 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. v8 engine Issues and PRs related to the V8 dependency.

Comments

@targos
Copy link
Member

targos commented Mar 30, 2024

re. test-shadow-realm-gc-module and test-shadow-realm-gc, I think we should just skip them. Possible solution can be, use the more reliable checkIfCollectableByCounting() to check if the ShadowRealm instance in the main context can be collected, but I feel that would make the test invalid too (e.g. the native side can still be leaking even though the JS instances are collectable), so we might as well just skip and figure out a better way to test it later.

re. test-net-write-fully-async-hex-string, looks like it's related to --expose-gc again. I'd suggest that we just open an issue to track this and the shadow realm tests, and skip them for now. They are likely flaking due to incorrect assumptions in the tests broken by V8's new GC strategy, not real bugs.

Originally posted by @joyeecheung in #51362 (comment)

targos added a commit to targos/node that referenced this issue Mar 30, 2024
targos added a commit that referenced this issue Mar 31, 2024
Refs: #52273
PR-URL: #51362
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@joyeecheung
Copy link
Member

joyeecheung commented Mar 31, 2024

Not sure if it's exactly related to test-net-write-fully-async-hex-string, but just something I notice: I discovered in my Oilpan migration prototypes that we may be under reporting externally-managed memory (#40786 (comment)), leading to poor GC performance.

@RedYetiDev RedYetiDev added flaky-test Issues and PRs related to the tests with unstable failures on the CI. v8 engine Issues and PRs related to the V8 dependency. labels Apr 20, 2024
@mhdawson
Copy link
Member

mhdawson commented May 2, 2024

@legendecas an FYI as I think you were working on shadow realm related stuff?

nodejs-github-bot pushed a commit that referenced this issue May 8, 2024
PR-URL: #52855
Refs: #52273
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this issue May 11, 2024
PR-URL: #52855
Refs: #52273
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this issue Jun 20, 2024
PR-URL: nodejs#52855
Refs: nodejs#52273
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
PR-URL: nodejs#52855
Refs: nodejs#52273
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
PR-URL: #52855
Refs: #52273
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit that referenced this issue Jul 19, 2024
PR-URL: #52855
Refs: #52273
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@jasnell
Copy link
Member

jasnell commented Sep 7, 2024

@targos @joyeecheung ... can either of you update here on what is needed to address the flaky tests? For test-net-write-fully-async-hex-string, it's not clear from the discussion here what the issue might be or how the test might need to change and I've been unable to reproduce any failure locally.

@RedYetiDev
Copy link
Member

RedYetiDev commented Sep 8, 2024

FWIW I found that when I increased the --max-old-space-size flag in test-shadow-realm-gc.js from 20 to 25, it greatly reduced the failures (but not entirely removed them).


I also couldn't reproduce the test-net-write-fully-async-hex-string and test-shadow-realm-gc-module failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

5 participants