Remove calls to APIs deprecated in V8 12.6 #52991
Labels
deprecations
Issues and PRs related to deprecations.
v8 engine
Issues and PRs related to the V8 dependency.
Comments
marco-ippolito
added
v8 engine
targos
pushed a commit
to targos/node
that referenced
this issue
May 15, 2024
|
Thanks for the heads up! I opened #52996 with your changes. |
targos
pushed a commit
that referenced
this issue
May 21, 2024
Closes: #52991 PR-URL: #52996 Fixes: #52991 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this issue
Jun 20, 2024
Closes: nodejs#52991 PR-URL: nodejs#52996 Fixes: nodejs#52991 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this issue
Jun 22, 2024
Closes: nodejs#52991 PR-URL: nodejs#52996 Fixes: nodejs#52991 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Both updates are trivial:
v8::ScriptOrigin's constructor no longer takes an Isolate (it was already unused)v8::SafeForTerminationScopeand the Isolate creation paramonly_terminate_in_safe_scopeare gone (they were already no-ops)See v8#185 for the fixes I made to keep V8's CI happy.
cc @joyeecheung
The text was updated successfully, but these errors were encountered: